Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the README.md file #127

Merged
merged 2 commits into from Jun 11, 2020
Merged

Update the README.md file #127

merged 2 commits into from Jun 11, 2020

Conversation

parauliya
Copy link
Contributor

@parauliya parauliya commented May 21, 2020 •
edited

  1. Update the links of boots, hegel
  2. Added osie, pbnj
  3. Added Packet and Equinix reference

@parauliya parauliya mentioned this pull request May 21, 2020
Closed
mmlb
mmlb suggested changes May 21, 2020
View reviewed changes
README.md Outdated Show resolved Hide resolved
@parauliya parauliya force-pushed the update_readme branch 4 times, most recently from c05163e to 0b5f116 Compare May 22, 2020 15:53
@parauliya parauliya requested a review from mmlb May 22, 2020 15:55
@parauliya parauliya added this to In Progress in Issues List May 25, 2020
gauravgahlot
gauravgahlot previously approved these changes May 26, 2020
View reviewed changes
@parauliya parauliya requested review from mmlb and removed request for mmlb May 26, 2020 07:22
@MalteJ MalteJ mentioned this pull request May 26, 2020
Closed
@parauliya parauliya self-assigned this May 27, 2020
@parauliya parauliya added the kind/documentation Categorizes issue or PR as related to documentation. label May 27, 2020
@mrmrcoleman mrmrcoleman moved this from In Progress to Blocked in Issues List May 29, 2020
mmlb
mmlb reviewed Jun 1, 2020
View reviewed changes
README.md Outdated Show resolved Hide resolved
grahamc
grahamc reviewed Jun 1, 2020
View reviewed changes
Copy link
Contributor

@grahamc grahamc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think about these minor nits?

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@parauliya parauliya requested a review from mmlb June 2, 2020 14:10
Issues List automation moved this from Blocked to In Progress Jun 2, 2020
nathangoulding
nathangoulding previously requested changes Jun 2, 2020
View reviewed changes
Copy link
Contributor

@nathangoulding nathangoulding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add pbnj, and four -> five

mmlb
mmlb suggested changes Jun 3, 2020
View reviewed changes
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
mmlb
mmlb suggested changes Jun 8, 2020
View reviewed changes
README.md Outdated Show resolved Hide resolved
@parauliya parauliya force-pushed the update_readme branch 4 times, most recently from b32bc39 to c4c7238 Compare June 9, 2020 07:22
@parauliya parauliya requested a review from mmlb June 9, 2020 08:36
@parauliya parauliya force-pushed the update_readme branch 3 times, most recently from 62cf79f to 96e7907 Compare June 11, 2020 05:58
@parauliya parauliya requested review from gauravgahlot and removed request for nathangoulding and mmlb June 11, 2020 06:06
gauravgahlot
gauravgahlot previously approved these changes Jun 11, 2020
View reviewed changes
Copy link
Contributor

@gauravgahlot gauravgahlot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gauravgahlot gauravgahlot added the ready-to-merge Signal to Mergify to merge the PR. label Jun 11, 2020
mmlb
mmlb previously approved these changes Jun 11, 2020
View reviewed changes
@grahamc grahamc removed the request for review from nathangoulding June 11, 2020 14:27
@parauliya
Update the README.md file
9fd076d 
Break down each sentence in the description in it's own line.
@parauliya
Update README.md file
2b88622 
1. Update the links of boots, hegel
2. Add osie
3. Add Packet and Equinix reference
@parauliya parauliya dismissed stale reviews from mmlb and gauravgahlot via 2b88622 June 11, 2020 14:40
@mergify mergify bot merged commit ebf8d99 into tinkerbell:master Jun 11, 2020
Issues List automation moved this from In Progress to Just shipped Jun 11, 2020
@parauliya parauliya deleted the update_readme branch July 8, 2020 06:27
@mmlb mmlb removed the ready-to-merge Signal to Mergify to merge the PR. label Jan 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grahamc grahamc grahamc approved these changes

@mmlb mmlb mmlb left review comments

@nathangoulding nathangoulding nathangoulding left review comments

@gauravgahlot gauravgahlot gauravgahlot left review comments

Assignees

@parauliya parauliya

Labels
kind/documentation Categorizes issue or PR as related to documentation.
Projects
No open projects
Issues List
  
Just shipped
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@parauliya @grahamc @mmlb @nathangoulding @gauravgahlot