Skip to content
This repository

Neo4jGraph and Neo4jBatchGraph should be put into a single subproject. #332

Closed
okram opened this Issue · 6 comments

4 participants

Marko A. Rodriguez Mike Bryant stephen mallette Peter Neubauer
Marko A. Rodriguez
Owner

To consolidate the implementations under one project, like OrientGraph and OrientBatchGraph, we should do the same for Neo4jGraph and Neo4jBatchGraph.

@peterneubauer

Marko A. Rodriguez okram closed this issue from a commit
Marko A. Rodriguez okram Fixed #332 .. all neo4j work is under a single package now -- also bu…
…t .batch into OrientDB package.
d739105
Marko A. Rodriguez okram closed this in d739105
Mike Bryant

Too late to object to this, but this change appears to have some unwanted side effects for me. All the HA dependencies get pulled in to my project, and via interactions I don't understand, tests that utilize a bootstrapped Neo4j server instance start failing with errors in - for what it's worth - the OnlineBackupKernelExtension not being able to bind to a particular port.

Now, I can probably work around these specific issues, but I mention it because it seems like something a user of the vanilla Neo4jGraph shouldn't have to worry about. Is there a case for re-modularizing the Blueprints Neo4j impl again so it's possible to use the community bits separately from the enterprise and advanced components?

(I'm not knowledgeable enough to speak about the license situation except to ask if it should be a concern?)

@peterneubauer

stephen mallette
Owner

re-opening for discussion so it doesn't get lost...

stephen mallette spmallette reopened this
Mike Bryant

Thanks Stephen. I have a branch here which moves just the Neo4jHaGraph into a separate subproject, leaving the Neo4jBatchGraph alone. This fixes my particular problem of weird stuff happening due to the HA dependencies, but obviously undoes part of the consolidation you wanted to address with this issue. Maybe there's a much easier solution.

Marko A. Rodriguez
Owner
okram commented
Peter Neubauer
Owner
stephen mallette
Owner

At this point I don't think we will be making any changes to this, especially since the neo4j2 implementation didn't add anything new to the mix. I suggest that users utilize exclusions to get rid of unwanted dependencies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.