Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Datomic blueprints implementation #238

Closed
wants to merge 19 commits into from

3 participants

@datablend

No description provided.

@spmallette
Owner

Thanks for your contribution. I just gave a quick glance to review this pull request from a Blueprints API implementation consistency perspective. One thing I noticed here:

https://github.com/tinkerpop/blueprints/pull/238/files#L3R76

The Element setProperty method should throw an IllegalArgumentException if the value is not a valid type expected by the underlying graph. If I'm following the diff right, the IllegalArgumentException is thrown by way of a call from here:

https://github.com/tinkerpop/blueprints/pull/238/files#L7R58

Is that correct?

@datablend

That is correct. Just tested it out to make sure:

Vertex davy = graph.addVertex(null);
davy.setProperty("name",new Test());

Exception in thread "main" java.lang.IllegalArgumentException: Object type com.tinkerpop.blueprints.pgm.impls.datomic.Test not supported
at com.tinkerpop.blueprints.pgm.impls.datomic.util.DatomicUtil.mapJavaTypeToDatomicType(DatomicUtil.java:54)
at com.tinkerpop.blueprints.pgm.impls.datomic.util.DatomicUtil.createKey(DatomicUtil.java:85)
at com.tinkerpop.blueprints.pgm.impls.datomic.util.DatomicUtil.existingAttributeDefinition(DatomicUtil.java:76)
at com.tinkerpop.blueprints.pgm.impls.datomic.util.DatomicUtil.createAttributeDefinition(DatomicUtil.java:59)
at com.tinkerpop.blueprints.pgm.impls.datomic.DatomicElement.setProperty(DatomicElement.java:84)
at com.tinkerpop.blueprints.pgm.impls.datomic.Test.main(Test.java:26)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:597)
at com.intellij.rt.execution.application.AppMain.main(AppMain.java:120)

@datablend datablend closed this
@datablend datablend reopened this
@ohpauleez

I would love to see this get merged in

@spmallette
Owner

I think we should consider options for getting Datomic into mainline after we release 2.1 in the coming weeks. Please let me know if you think there is anything we need to think about or consider in terms of doing that.

@datablend

Not a lot I guess. The only disadvantage I can think off is that people need to manually install the datomic dependency.

@spmallette
Owner

after a number of discussions on tinkerpop-contributors, it appears we've basically decided to keep your blueprints implementation separate from the mainline of blueprints development. is it ok to close this pull request?

from there it would be cool to collaborate with you to build rexster configuration classes in your repos. i think i could do that pretty quickly for you if you can talk to me a little bit about what the configuration options are.

@datablend

Ok. Will close this pull request and create a new repository specifically for FluxGraph.

@datablend datablend closed this
@spmallette
Owner

will FluxGraph cover both the mongodb and dataomic implementations?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Apr 11, 2012
  1. Created datomic graph module

    unknown authored
  2. Update of parent pom

    unknown authored
  3. Updated documentation

    unknown authored
  4. Updated datomic dependencies

    unknown authored
  5. Initial implementation

    unknown authored
Commits on Apr 12, 2012
  1. Updated implementation to allows for the creation of automatic indexe…

    unknown authored
    …s (basically filtering on attribute keys)
Commits on Apr 19, 2012
  1. - Updated to version 0.1.3007 of Datomic

    unknown authored
    - Making use of the raw index access where appropriate
Commits on Apr 20, 2012
  1. Adde datomic logo for docs

    unknown authored
  2. Datomic documentation

    unknown authored
Commits on May 2, 2012
  1. Updated to latest datomic build (0.1.3065)

    unknown authored
Commits on Jul 11, 2012
  1. First update to support the 2.1.0 Blueprints API

    Davy Suvee authored
  2. Merge remote-tracking branch 'upstream/master'

    Davy Suvee authored
Commits on Jul 12, 2012
  1. Improved overall iteration

    Davy Suvee authored
Commits on Jul 13, 2012
Commits on Sep 9, 2012
  1. Time-aware extensions to the core blueprints API

    Davy Suvee authored
  2. Updated datomic-graph implementation with time-aware features (includ…

    Davy Suvee authored
    …ing time-scoped iteration)
Commits on Sep 11, 2012
  1. Added datomic(-free) dependency to the project deps ... (is now autom…

    Davy Suvee authored
    …atically uploaded to clojars at build time)
Commits on Sep 14, 2012
  1. An example demonstrating the use of time-scoped iteration of vertices…

    Davy Suvee authored
    … and edges
Something went wrong with that request. Please try again.