Skip to content
This repository

Datomic blueprints implementation #238

Closed
wants to merge 19 commits into from

3 participants

Davy Suvee stephen mallette Paul deGrandis
Davy Suvee

No description provided.

stephen mallette
Owner

Thanks for your contribution. I just gave a quick glance to review this pull request from a Blueprints API implementation consistency perspective. One thing I noticed here:

https://github.com/tinkerpop/blueprints/pull/238/files#L3R76

The Element setProperty method should throw an IllegalArgumentException if the value is not a valid type expected by the underlying graph. If I'm following the diff right, the IllegalArgumentException is thrown by way of a call from here:

https://github.com/tinkerpop/blueprints/pull/238/files#L7R58

Is that correct?

Davy Suvee

That is correct. Just tested it out to make sure:

Vertex davy = graph.addVertex(null);
davy.setProperty("name",new Test());

Exception in thread "main" java.lang.IllegalArgumentException: Object type com.tinkerpop.blueprints.pgm.impls.datomic.Test not supported
at com.tinkerpop.blueprints.pgm.impls.datomic.util.DatomicUtil.mapJavaTypeToDatomicType(DatomicUtil.java:54)
at com.tinkerpop.blueprints.pgm.impls.datomic.util.DatomicUtil.createKey(DatomicUtil.java:85)
at com.tinkerpop.blueprints.pgm.impls.datomic.util.DatomicUtil.existingAttributeDefinition(DatomicUtil.java:76)
at com.tinkerpop.blueprints.pgm.impls.datomic.util.DatomicUtil.createAttributeDefinition(DatomicUtil.java:59)
at com.tinkerpop.blueprints.pgm.impls.datomic.DatomicElement.setProperty(DatomicElement.java:84)
at com.tinkerpop.blueprints.pgm.impls.datomic.Test.main(Test.java:26)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:597)
at com.intellij.rt.execution.application.AppMain.main(AppMain.java:120)

Davy Suvee datablend closed this April 11, 2012
Davy Suvee datablend reopened this April 11, 2012
Paul deGrandis

I would love to see this get merged in

stephen mallette
Owner

I think we should consider options for getting Datomic into mainline after we release 2.1 in the coming weeks. Please let me know if you think there is anything we need to think about or consider in terms of doing that.

Davy Suvee

Not a lot I guess. The only disadvantage I can think off is that people need to manually install the datomic dependency.

stephen mallette
Owner

after a number of discussions on tinkerpop-contributors, it appears we've basically decided to keep your blueprints implementation separate from the mainline of blueprints development. is it ok to close this pull request?

from there it would be cool to collaborate with you to build rexster configuration classes in your repos. i think i could do that pretty quickly for you if you can talk to me a little bit about what the configuration options are.

Davy Suvee

Ok. Will close this pull request and create a new repository specifically for FluxGraph.

Davy Suvee datablend closed this October 10, 2012
stephen mallette
Owner

will FluxGraph cover both the mongodb and dataomic implementations?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Showing 19 unique commits by 2 authors.

Apr 11, 2012
Created datomic graph module db853cb
Update of parent pom b1c22e7
Updated documentation 389052b
Updated datomic dependencies 3e99b62
Initial implementation bcccb64
Apr 12, 2012
Updated implementation to support IndexableGraph interface 3d59687
Updated implementation to allows for the creation of automatic indexe…
…s (basically filtering on attribute keys)
66a70bb
Apr 19, 2012
- Updated to version 0.1.3007 of Datomic
- Making use of the raw index access where appropriate
d94054c
Apr 20, 2012
Adde datomic logo for docs 4b17cc8
Datomic documentation faf4283
May 02, 2012
Updated to latest datomic build (0.1.3065) 6554ac8
Jul 11, 2012
Davy Suvee First update to support the 2.1.0 Blueprints API 7dc5ff5
Davy Suvee Merge remote-tracking branch 'upstream/master' beb167e
Jul 12, 2012
Davy Suvee Improved overall iteration ca512bd
Jul 13, 2012
Davy Suvee DatomicGraph is now implementing new KeyIndexableGraph interface 5ff9ffa
Sep 09, 2012
Davy Suvee Time-aware extensions to the core blueprints API 0816259
Davy Suvee Updated datomic-graph implementation with time-aware features (includ…
…ing time-scoped iteration)
9cb378e
Sep 11, 2012
Davy Suvee Added datomic(-free) dependency to the project deps ... (is now autom…
…atically uploaded to clojars at build time)
f78ab48
Sep 14, 2012
Davy Suvee An example demonstrating the use of time-scoped iteration of vertices…
… and edges
9c7cb0b
Something went wrong with that request. Please try again.