Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Datomic blueprints implementation #238
Thanks for your contribution. I just gave a quick glance to review this pull request from a Blueprints API implementation consistency perspective. One thing I noticed here:
The Element setProperty method should throw an IllegalArgumentException if the value is not a valid type expected by the underlying graph. If I'm following the diff right, the IllegalArgumentException is thrown by way of a call from here:
Is that correct?
That is correct. Just tested it out to make sure:
Vertex davy = graph.addVertex(null);
Exception in thread "main" java.lang.IllegalArgumentException: Object type com.tinkerpop.blueprints.pgm.impls.datomic.Test not supported
after a number of discussions on tinkerpop-contributors, it appears we've basically decided to keep your blueprints implementation separate from the mainline of blueprints development. is it ok to close this pull request?
from there it would be cool to collaborate with you to build rexster configuration classes in your repos. i think i could do that pretty quickly for you if you can talk to me a little bit about what the configuration options are.