Cagatay Kavukcuoglu
tinkerware

Aug 20, 2016
tinkerware commented on pull request pholser/junit-quickcheck#126
@tinkerware

I think this looks all right.

Aug 20, 2016
@tinkerware

The output for these cases look great. I'm going to look at the PR today.

Aug 18, 2016
Aug 17, 2016
@tinkerware

This looks really good! I agree ValuesOf loses its current appeal with this scheme.

Aug 17, 2016
tinkerware commented on pull request opentracing/opentracing-java#43
@tinkerware

If Java supported multiple return values as Go does, this would've been simple The idiomatic way this happens in Java is either through a checke…

Aug 17, 2016
tinkerware commented on pull request opentracing/opentracing-java#43
@tinkerware

I'd be in favor of adding something like this: public interface SpanContext { SpanContext NONE = NullSpanContext.INSTANCE; Iterable<Map.Entry<String,

Aug 17, 2016
@tinkerware

How about EXHAUSTIVE and SAMPLING as mode names? I find TUPLES and PERMUTATIONS too generic; they would make me look up the meaning every time I us…

Aug 17, 2016
tinkerware commented on pull request opentracing/opentracing-java#43
@tinkerware

I have to second this. There's no good reason to introduce null return values to the API when we can easily return an empty context.

Aug 17, 2016
tinkerware commented on pull request opentracing/opentracing-java#43
@tinkerware

It's not a spec, not a reference implementation, it is not even used as a base by the two actual production implementations of the API that I know…

Aug 16, 2016
@tinkerware

Also, a short pointer to how to use the seed to recreate the failure after the printed seed would be helpful; I keep having to look it up every tim…

Aug 16, 2016
@tinkerware

I'm assuming you meant to include the cause from the result of the shrink and not the first counter-example. I think the prologue looks good. For t…

Aug 16, 2016
Aug 16, 2016
@tinkerware

Yes, that's better. Would that code path contain anything from the classes under test, the generators or the counter example hook you've added rece…

Aug 16, 2016
Aug 12, 2016
@tinkerware
Exception from shrunk example is not logged
Aug 12, 2016
Aug 11, 2016
Aug 8, 2016
Jul 29, 2016
Jul 28, 2016
@tinkerware

Also, while Maven Shade renaming works for command-line builds, it leaves at least IntelliJ unable to resolve the renamed classes. I'm not sure abo…

Jul 28, 2016
@tinkerware

I've just run into this while generating immutable value classes that make use of the HdrHistogram library. The package name this library uses is o…

Jul 25, 2016
@tinkerware

Once baggage is set on a span, all future children of that span must inherit the baggage. Any other scenarios, including setting baggage on a pare…

Jul 25, 2016
@tinkerware
  • @tinkerware 2c2815c
    Replace Format<C> with Format<? super C>
Jul 25, 2016
@tinkerware
  • @tinkerware c723be0
    Replace Format<C> with Format<? super C>
Jul 25, 2016
Jul 25, 2016
tinkerware commented on pull request opentracing/opentracing-java#33
@tinkerware

behavierbehavior

Jul 25, 2016
@tinkerware

@bensigelman My concern with the set/get baggage item API on Span is the risk of inconsistent linking & baggage behavior that OT clients need to ac…

Jul 24, 2016
Jul 23, 2016