Permalink
Browse files

trap cleanup

IRQ_OFFSET -> T_IRQ0 (a trap number not an IRQ number)
T_SYSCALL 0x30 -> 0x40 (move out of IRQ range)
  • Loading branch information...
1 parent 887f196 commit 2de1c550cab8a5812dc9965313fce00816a003eb @rsc rsc committed Jul 12, 2009
Showing with 7 additions and 7 deletions.
  1. +2 −2 ioapic.c
  2. +3 −3 lapic.c
  3. +2 −2 picirq.c
View
@@ -62,7 +62,7 @@ ioapicinit(void)
// Mark all interrupts edge-triggered, active high, disabled,
// and not routed to any CPUs.
for(i = 0; i <= maxintr; i++){
- ioapicwrite(REG_TABLE+2*i, INT_DISABLED | (IRQ_OFFSET + i));
+ ioapicwrite(REG_TABLE+2*i, INT_DISABLED | (T_IRQ0 + i));
ioapicwrite(REG_TABLE+2*i+1, 0);
}
}
@@ -76,6 +76,6 @@ ioapicenable(int irq, int cpunum)
// Mark interrupt edge-triggered, active high,
// enabled, and routed to the given cpunum,
// which happens to be that cpu's APIC ID.
- ioapicwrite(REG_TABLE+2*irq, IRQ_OFFSET + irq);
+ ioapicwrite(REG_TABLE+2*irq, T_IRQ0 + irq);
ioapicwrite(REG_TABLE+2*irq+1, cpunum << 24);
}
View
@@ -52,14 +52,14 @@ lapicinit(int c)
return;
// Enable local APIC; set spurious interrupt vector.
- lapicw(SVR, ENABLE | (IRQ_OFFSET+IRQ_SPURIOUS));
+ lapicw(SVR, ENABLE | (T_IRQ0 + IRQ_SPURIOUS));
// The timer repeatedly counts down at bus frequency
// from lapic[TICR] and then issues an interrupt.
// If xv6 cared more about precise timekeeping,
// TICR would be calibrated using an external time source.
lapicw(TDCR, X1);
- lapicw(TIMER, PERIODIC | (IRQ_OFFSET + IRQ_TIMER));
+ lapicw(TIMER, PERIODIC | (T_IRQ0 + IRQ_TIMER));
lapicw(TICR, 10000000);
// Disable logical interrupt lines.
@@ -72,7 +72,7 @@ lapicinit(int c)
lapicw(PCINT, MASKED);
// Map error interrupt to IRQ_ERROR.
- lapicw(ERROR, IRQ_OFFSET+IRQ_ERROR);
+ lapicw(ERROR, T_IRQ0 + IRQ_ERROR);
// Clear error status register (requires back-to-back writes).
lapicw(ESR, 0);
View
@@ -45,7 +45,7 @@ picinit(void)
outb(IO_PIC1, 0x11);
// ICW2: Vector offset
- outb(IO_PIC1+1, IRQ_OFFSET);
+ outb(IO_PIC1+1, T_IRQ0);
// ICW3: (master PIC) bit mask of IR lines connected to slaves
// (slave PIC) 3-bit # of slave's connection to master
@@ -63,7 +63,7 @@ picinit(void)
// Set up slave (8259A-2)
outb(IO_PIC2, 0x11); // ICW1
- outb(IO_PIC2+1, IRQ_OFFSET + 8); // ICW2
+ outb(IO_PIC2+1, T_IRQ0 + 8); // ICW2
outb(IO_PIC2+1, IRQ_SLAVE); // ICW3
// NB Automatic EOI mode doesn't tend to work on the slave.
// Linux source code says it's "to be investigated".

0 comments on commit 2de1c55

Please sign in to comment.