Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -33,4 +33,7 @@

# binary out
/tinyauth.db
/resources
/resources

# debug files
__debug_*
12 changes: 2 additions & 10 deletions internal/controller/proxy_controller.go
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,8 @@ func NewProxyController(config ProxyControllerConfig, router *gin.RouterGroup, a

func (controller *ProxyController) SetupRoutes() {
proxyGroup := controller.router.Group("/auth")
proxyGroup.Any("/:proxy", controller.proxyHandler)
proxyGroup.GET("/:proxy", controller.proxyHandler)
proxyGroup.POST("/:proxy", controller.proxyHandler)
Comment thread
steveiliop56 marked this conversation as resolved.
}

func (controller *ProxyController) proxyHandler(c *gin.Context) {
Expand All @@ -67,15 +68,6 @@ func (controller *ProxyController) proxyHandler(c *gin.Context) {
return
}

if req.Proxy != "envoy" && c.Request.Method != http.MethodGet {
log.Warn().Str("method", c.Request.Method).Msg("Invalid method for proxy")
c.JSON(405, gin.H{
"status": 405,
"message": "Method Not Allowed",
})
return
}

isBrowser := strings.Contains(c.Request.Header.Get("Accept"), "text/html")

if isBrowser {
Expand Down
7 changes: 0 additions & 7 deletions internal/controller/proxy_controller_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -80,13 +80,6 @@ func TestProxyHandler(t *testing.T) {

assert.Equal(t, 400, recorder.Code)

// Test invalid method
recorder = httptest.NewRecorder()
req = httptest.NewRequest("POST", "/api/auth/traefik", nil)
router.ServeHTTP(recorder, req)

assert.Equal(t, 405, recorder.Code)

// Test logged out user (traefik/caddy)
recorder = httptest.NewRecorder()
req = httptest.NewRequest("GET", "/api/auth/traefik", nil)
Expand Down
2 changes: 2 additions & 0 deletions internal/middleware/context_middleware.go
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,7 @@ func (m *ContextMiddleware) Middleware() gin.HandlerFunc {
goto basic
}

m.auth.RefreshSessionCookie(c)
Comment thread
steveiliop56 marked this conversation as resolved.
c.Set("context", &config.UserContext{
Username: cookie.Username,
Name: cookie.Name,
Expand All @@ -89,6 +90,7 @@ func (m *ContextMiddleware) Middleware() gin.HandlerFunc {
goto basic
}

m.auth.RefreshSessionCookie(c)
Comment thread
steveiliop56 marked this conversation as resolved.
c.Set("context", &config.UserContext{
Username: cookie.Username,
Name: cookie.Name,
Expand Down
45 changes: 38 additions & 7 deletions internal/service/auth_service.go
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
package service

import (
"context"
"errors"
"fmt"
"regexp"
Expand Down Expand Up @@ -43,7 +42,6 @@ type AuthService struct {
loginMutex sync.RWMutex
ldap *LdapService
database *gorm.DB
ctx context.Context
}

func NewAuthService(config AuthServiceConfig, docker *DockerService, ldap *LdapService, database *gorm.DB) *AuthService {
Expand All @@ -57,7 +55,6 @@ func NewAuthService(config AuthServiceConfig, docker *DockerService, ldap *LdapS
}

func (auth *AuthService) Init() error {
auth.ctx = context.Background()
return nil
}

Expand Down Expand Up @@ -217,7 +214,7 @@ func (auth *AuthService) CreateSessionCookie(c *gin.Context, data *config.Sessio
OAuthName: data.OAuthName,
}

err = gorm.G[model.Session](auth.database).Create(auth.ctx, &session)
err = gorm.G[model.Session](auth.database).Create(c, &session)

if err != nil {
return err
Expand All @@ -228,14 +225,48 @@ func (auth *AuthService) CreateSessionCookie(c *gin.Context, data *config.Sessio
return nil
}

func (auth *AuthService) RefreshSessionCookie(c *gin.Context) error {
cookie, err := c.Cookie(auth.config.SessionCookieName)

if err != nil {
return err
}

session, err := gorm.G[model.Session](auth.database).Where("uuid = ?", cookie).First(c)

if err != nil {
return err
}

currentTime := time.Now().Unix()

if session.Expiry-currentTime > int64(time.Hour.Seconds()) {
return nil
}
Comment thread
steveiliop56 marked this conversation as resolved.

newExpiry := currentTime + int64(time.Hour.Seconds())

_, err = gorm.G[model.Session](auth.database).Where("uuid = ?", cookie).Updates(c, model.Session{
Expiry: newExpiry,
})

if err != nil {
return err
}

c.SetCookie(auth.config.SessionCookieName, cookie, int(time.Hour.Seconds()), "/", fmt.Sprintf(".%s", auth.config.CookieDomain), auth.config.SecureCookie, true)

return nil
}
Comment thread
steveiliop56 marked this conversation as resolved.

func (auth *AuthService) DeleteSessionCookie(c *gin.Context) error {
cookie, err := c.Cookie(auth.config.SessionCookieName)

if err != nil {
return err
}

_, err = gorm.G[model.Session](auth.database).Where("uuid = ?", cookie).Delete(auth.ctx)
_, err = gorm.G[model.Session](auth.database).Where("uuid = ?", cookie).Delete(c)

if err != nil {
return err
Expand All @@ -253,7 +284,7 @@ func (auth *AuthService) GetSessionCookie(c *gin.Context) (config.SessionCookie,
return config.SessionCookie{}, err
}

session, err := gorm.G[model.Session](auth.database).Where("uuid = ?", cookie).First(auth.ctx)
session, err := gorm.G[model.Session](auth.database).Where("uuid = ?", cookie).First(c)

if err != nil {
return config.SessionCookie{}, err
Expand All @@ -266,7 +297,7 @@ func (auth *AuthService) GetSessionCookie(c *gin.Context) (config.SessionCookie,
currentTime := time.Now().Unix()

if currentTime > session.Expiry {
_, err = gorm.G[model.Session](auth.database).Where("uuid = ?", cookie).Delete(auth.ctx)
_, err = gorm.G[model.Session](auth.database).Where("uuid = ?", cookie).Delete(c)
if err != nil {
log.Error().Err(err).Msg("Failed to delete expired session")
}
Expand Down