Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build failed with intercom-android v5.1.6 #238

Closed
forsen opened this issue Nov 14, 2018 · 5 comments

Comments

@forsen
Copy link

commented Nov 14, 2018

react-native-intercom depends on io.intercom.android:intercom-sdk-base:5.+. A few hours ago version 5.1.6 of intercom-android was released, including a bump of appCompat-v7 from 27.x to 28. In each android project all dependencies have to be built with the same appCompat version.

It is recommended to use the same versions as RN does, and latest RN is currently using this:

    buildToolsVersion = "27.0.3"
    compileSdkVersion = 27
    supportLibVersion = "27.1.1"

intercom-android should be pinned to v5.1.5 as long as RN still use 27.x as build/compile/supportLib version.

sonicdoe added a commit to figureaps/react-native-intercom that referenced this issue Nov 15, 2018

@pushpush

This comment has been minimized.

Copy link

commented Nov 15, 2018

My fix.
FIle - android/build.gradle

subprojects {
    afterEvaluate {project ->
        if (project.hasProperty("android")) {
            configurations.all {
                resolutionStrategy.force 'io.intercom.android:intercom-sdk-base:5.1.5'
            }
        }
    }
}
@TareqElMasri

This comment has been minimized.

Copy link

commented Nov 15, 2018

@pushpush Man, you just saved my weekend, you're a hero! Thanks a lot!

@mrikirill

This comment has been minimized.

Copy link

commented Nov 29, 2018

For expokit, this helped me:
android/build.gradle

subprojects {
    afterEvaluate {project ->
        if (project.hasProperty("android")) {
            configurations.all {
                resolutionStrategy.force 'io.intercom.android:intercom-sdk-base:5.1.5'
                resolutionStrategy.force 'com.android.support:recyclerview-v7:27.1.1'
            }
        }
    }
}
@mathieumg

This comment has been minimized.

Copy link
Contributor

commented Jan 5, 2019

Had to use @pushpush 's workaround but it seems fixed now, removed it and got a green build!

Edit: Ugh, seems like it was only working for the debug build. :(

@mathieumg

This comment has been minimized.

Copy link
Contributor

commented Jan 8, 2019

React-Native 0.58 (currently in RC2) finally bumps to SDK 28: facebook/react-native@8e39451

@browniefed browniefed closed this Feb 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.