Skip to content

all: fix -gc=none #1236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 13, 2020
Merged

all: fix -gc=none #1236

merged 1 commit into from
Jul 13, 2020

Conversation

@aykevl
Copy link
Member

@aykevl aykevl commented Jul 12, 2020

This option was broken for a long time, in part because we didn't test for it. This commit fixes that and adds a test to make sure it won't break again unnoticed.

@aykevl
all: fix -gc=none
5bd3a99 
This option was broken for a long time, in part because we didn't test
for it. This commit fixes that and adds a test to make sure it won't
break again unnoticed.
@aykevl aykevl mentioned this pull request Jul 12, 2020
Merged
niaow
niaow approved these changes Jul 12, 2020
View reviewed changes
Copy link
Member

@niaow niaow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aykevl
Copy link
Member Author

aykevl commented Jul 12, 2020

@deadprogram TinyHCI appears to be stuck?

@deadprogram
Copy link
Member

deadprogram commented Jul 13, 2020

All passed, now merging.

@deadprogram deadprogram merged commit 05495c4 into dev Jul 13, 2020
@deadprogram deadprogram deleted the fix-gc-none branch July 13, 2020 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@niaow niaow niaow approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@aykevl @deadprogram @niaow