Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

making Docker build resilient #168

Merged
merged 1 commit into from Feb 5, 2019

Conversation

Projects
None yet
3 participants
@universam1
Copy link
Contributor

universam1 commented Feb 5, 2019

Currently, if the user hasn't run
git submodule update --init beforehand, the docker build will fail

This little addition makes the build atomic and ready for automatic CI tests for the future

Samuel Lang
making Docker build resilient
Currently, if the user hasn't run
`git submodule update --init` beforehand, the docker build will fail

This little addition makes the build atomic and ready for automatic CI tests for the future

@universam1 universam1 referenced this pull request Feb 5, 2019

Closed

docker: unknown blob. #166

@OrangeTux

This comment has been minimized.

Copy link

OrangeTux commented Feb 5, 2019

I can confirm that this patch works.

@deadprogram

This comment has been minimized.

Copy link
Member

deadprogram commented Feb 5, 2019

Thank you @universam1 for the PR and @OrangeTux for verifying. Now merging.

@deadprogram deadprogram merged commit 70f1064 into tinygo-org:master Feb 5, 2019

@universam1 universam1 deleted the universam1:fixDockerbuild branch Feb 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.