Generalize -scheduler=none to support most platforms #895
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Member
Author
|
I rebased this on the final merged version of #828, and added in the build tag fix. This is ready for review I think. |
aykevl
reviewed
Mar 17, 2020
Member
aykevl
left a comment
aykevl
left a comment
There was a problem hiding this comment.
Looks good to me.
Can you squash the third commit together with the first? That makes sure bisecting keeps working. (hint: git rebase -i dev if you didn't know).
Member
|
Oh well I'll merge it anyway. Not too big of a deal. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based on top of #828, and generalizes the "none" scheduler to work on platforms other than AVR. It should now work on all platforms except WebAssembly. Init should also be run in the main goroutine when using a scheduler, but this is not yet possible as the runtime must be initialized before starting a goroutine.