feature: add displays subpackage #13
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… subpackage Signed-off-by: deadprogram <ron@hybridgroup.com>
Signed-off-by: deadprogram <ron@hybridgroup.com>
Signed-off-by: deadprogram <ron@hybridgroup.com>
Member
Author
|
Rebased against |
Member
Author
|
I will also update go mod... stand by. |
Member
|
Requirements have been met, so now merging. Thanks 👍 |
Member
Author
|
Thanks @conejoninja |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new subpackage named
displaysintended to make it easier to use one of the supported display devices.It also adds a
terminal.Display()method that is just a wrapper for calling the display's method of the same name. This is required for displays such as e-ink or slow OLED screens.Even though
display.Display()is a no-op on many displays, this will ensure compatibility with these slower displays.This PR requires #12 be merged first and then this one rebased.