Skip to content

fix(release): build linux arm64 target artifact#2404

Merged
senamakel merged 1 commit into
tinyhumansai:mainfrom
aqilaziz:codex/1599-linux-arm64-target-build
May 23, 2026
Merged

fix(release): build linux arm64 target artifact#2404
senamakel merged 1 commit into
tinyhumansai:mainfrom
aqilaziz:codex/1599-linux-arm64-target-build

Conversation

@aqilaziz
Copy link
Copy Markdown
Contributor

@aqilaziz aqilaziz commented May 21, 2026

Summary

  • make the Linux ARM64 release helper build the explicit aarch64-unknown-linux-gnu target
  • install the Rust target when rustup is available
  • package the binary from target/aarch64-unknown-linux-gnu/release so the tarball name and contents match

Refs #1599

Checks

  • bash -n scripts/release/build-linux-arm64.sh
  • git diff --check

Summary by CodeRabbit

  • Chores
    • Improved ARM64 release build process to ensure proper target configuration and correct binary staging for architecture-specific releases.

Review Change Stack

@aqilaziz aqilaziz requested a review from a team May 21, 2026 02:34
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 21, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 03919ed8-1bd4-40c0-8c56-7b4a160bbf31

📥 Commits

Reviewing files that changed from the base of the PR and between 6281aea and f883a3a.

📒 Files selected for processing (1)
  • scripts/release/build-linux-arm64.sh

📝 Walkthrough

Walkthrough

The ARM64 build script now conditionally installs the aarch64-unknown-linux-gnu Rust target via rustup when available, explicitly targets that architecture during compilation, and updates the artifact staging path to retrieve the built binary from the target-specific output directory.

Changes

ARM64 build target configuration

Layer / File(s) Summary
ARM64 target installation and cargo build configuration
scripts/release/build-linux-arm64.sh
Script conditionally installs the aarch64-unknown-linux-gnu Rust target via rustup target add, builds openhuman-core with cargo build --target "$TARGET", and updates the binary staging path to copy from target/${TARGET}/release/ instead of the default release directory.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 A script hops cross the ARM64 plain,
With rustup's gift, no target pain,
Cargo builds where the aarch64 shines,
Staging binaries from the right lines! ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'fix(release): build linux arm64 target artifact' directly and specifically describes the main change: ensuring the Linux ARM64 build produces the correct target-specific artifact.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@senamakel senamakel merged commit 0d83851 into tinyhumansai:main May 23, 2026
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants