fix(i18n): add missing German keys for MCP Server settings#2484
fix(i18n): add missing German keys for MCP Server settings#2484CodeGhost21 wants to merge 1 commit into
Conversation
…ious The German locale was missing 20 keys introduced by tinyhumansai#2378: - `settings.developerMenu.mcpServer.{title,desc}` - `settings.mcpServer.*` (16 MCP server configuration strings) - `subconscious.providerUnavailableTitle`, `subconscious.providerSettings` This caused `pnpm i18n:check` and the two German-completeness Vitest suites (`I18nContext.test.tsx`, `coverage.test.ts`) to fail on main, which in turn cascaded into Frontend Unit Tests, Frontend Coverage (Vitest), and Coverage Gate failures on every open PR. Product names (Claude Desktop, Cursor, Codex, Zed) are intentionally kept untranslated.
📝 WalkthroughWalkthroughThis PR extends German localization support by adding translation strings to two localization chunks. It introduces subconscious provider UI text in ChangesGerman Localization Additions
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
|
Superseded by #2482, which bundled the same German MCP / subconscious key additions alongside the socketio origin fix and landed first. |
Summary
The German locale was missing 20 keys introduced by the MCP Server settings panel (originally added without German translations and uncaught when the German locale itself was added in #2378). This causes
pnpm i18n:checkto fail onmain, which cascades into:i18n CoverageworkflowFrontend Unit Tests(2 failures:I18nContext.test.tsx > keeps the German locale complete against English keys,coverage.test.ts > locale de defines every English key)Frontend Coverage (Vitest)(same 2 tests fail)Coverage Gate (diff-cover ≥ 80%)(cancelled because Frontend Coverage failed)Every open PR is currently red on these checks for this reason — see #2249 for an example.
Changes
app/src/lib/i18n/chunks/de-3.ts: +2 keys (subconscious.providerUnavailableTitle,subconscious.providerSettings)app/src/lib/i18n/chunks/de-5.ts: +18 keys (settings.developerMenu.mcpServer.{title,desc},settings.mcpServer.*)Product names (Claude Desktop, Cursor, Codex, Zed) are intentionally kept in English — they show as "untranslated" in the report but the check passes (untranslated count is informational, not a failure).
Verification
Test plan
pnpm i18n:checkexits 0I18nContext.test.tsxGerman-completeness suite passescoverage.test.ts > locale de defines every English keypasses