Skip to content

fix(i18n): add missing German keys for MCP Server settings#2484

Closed
CodeGhost21 wants to merge 1 commit into
tinyhumansai:mainfrom
CodeGhost21:fix/i18n-de-mcpserver-keys
Closed

fix(i18n): add missing German keys for MCP Server settings#2484
CodeGhost21 wants to merge 1 commit into
tinyhumansai:mainfrom
CodeGhost21:fix/i18n-de-mcpserver-keys

Conversation

@CodeGhost21
Copy link
Copy Markdown
Contributor

@CodeGhost21 CodeGhost21 commented May 22, 2026

Summary

The German locale was missing 20 keys introduced by the MCP Server settings panel (originally added without German translations and uncaught when the German locale itself was added in #2378). This causes pnpm i18n:check to fail on main, which cascades into:

  • i18n Coverage workflow
  • Frontend Unit Tests (2 failures: I18nContext.test.tsx > keeps the German locale complete against English keys, coverage.test.ts > locale de defines every English key)
  • Frontend Coverage (Vitest) (same 2 tests fail)
  • Coverage Gate (diff-cover ≥ 80%) (cancelled because Frontend Coverage failed)

Every open PR is currently red on these checks for this reason — see #2249 for an example.

Changes

  • app/src/lib/i18n/chunks/de-3.ts: +2 keys (subconscious.providerUnavailableTitle, subconscious.providerSettings)
  • app/src/lib/i18n/chunks/de-5.ts: +18 keys (settings.developerMenu.mcpServer.{title,desc}, settings.mcpServer.*)

Product names (Claude Desktop, Cursor, Codex, Zed) are intentionally kept in English — they show as "untranslated" in the report but the check passes (untranslated count is informational, not a failure).

Verification

$ pnpm i18n:check
## de  (1947 keys)
  missing:        0
  extra:          0
  drifted chunks: 0
exit: 0

$ pnpm exec vitest run src/lib/i18n/__tests__/I18nContext.test.tsx src/lib/i18n/__tests__/coverage.test.ts
Test Files  2 passed (2)
     Tests  50 passed (50)

Test plan

  • pnpm i18n:check exits 0
  • I18nContext.test.tsx German-completeness suite passes
  • coverage.test.ts > locale de defines every English key passes
  • Prettier formatting clean

…ious

The German locale was missing 20 keys introduced by tinyhumansai#2378:

- `settings.developerMenu.mcpServer.{title,desc}`
- `settings.mcpServer.*` (16 MCP server configuration strings)
- `subconscious.providerUnavailableTitle`, `subconscious.providerSettings`

This caused `pnpm i18n:check` and the two German-completeness Vitest
suites (`I18nContext.test.tsx`, `coverage.test.ts`) to fail on main,
which in turn cascaded into Frontend Unit Tests, Frontend Coverage
(Vitest), and Coverage Gate failures on every open PR.

Product names (Claude Desktop, Cursor, Codex, Zed) are intentionally
kept untranslated.
@CodeGhost21 CodeGhost21 requested a review from a team May 22, 2026 08:22
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 22, 2026

📝 Walkthrough

Walkthrough

This PR extends German localization support by adding translation strings to two localization chunks. It introduces subconscious provider UI text in de-3.ts and comprehensive MCP server configuration panel translations in de-5.ts, including client selector labels and error messaging.

Changes

German Localization Additions

Layer / File(s) Summary
Subconscious feature German translations
app/src/lib/i18n/chunks/de-3.ts
Two new German translation keys added to the de3 map for subconscious provider unavailable title and provider settings labels.
MCP server UI German translations
app/src/lib/i18n/chunks/de-5.ts
Twenty-two new German translation keys added to the de5 map covering MCP server configuration UI: developer menu titles, section labels, copy/open config actions, error messages, binary-not-found guidance, and MCP client selector names (Claude Desktop, Cursor, Codex, Zed).

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

  • tinyhumansai/openhuman#2378: Overlapping German translation chunk updates in the same i18n modules for subconscious and related namespace localization.
  • tinyhumansai/openhuman#2440: Parallel localization work on MCP server settings translation chunks, though for a different language locale (zh-CN-5.ts vs. de-5.ts).

Suggested labels

working

Suggested reviewers

  • graycyrus

Poem

🐰 Ah, translation time—a hoppy task!
German words in proper mask,
Subconscious whispers, MCP's call,
Locale chunks now speak it all!
✨ Multilingual magic, strings so true 🌍

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: adding missing German translation keys for MCP Server settings. It is specific, concise, and directly reflects the changeset content.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot added the working A PR that is being worked on by the team. label May 22, 2026
@CodeGhost21
Copy link
Copy Markdown
Contributor Author

Superseded by #2482, which bundled the same German MCP / subconscious key additions alongside the socketio origin fix and landed first. pnpm i18n:check on current main (62727e1d) reports 0 missing for de.

@CodeGhost21 CodeGhost21 deleted the fix/i18n-de-mcpserver-keys branch May 22, 2026 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

working A PR that is being worked on by the team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant