Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Multiple toolbars are in the same row instead of separate rows #4819

Open
ronfogel opened this Issue Feb 9, 2019 · 7 comments

Comments

Projects
None yet
6 participants
@ronfogel
Copy link

ronfogel commented Feb 9, 2019

Do you want to request a feature or report a bug?
bug

What is the current behavior?
multiple toolbars (toolbar1, toolbar2, toolbar3) are in the same line (both implementations - toolbar1,2,3 or toolbar as an array)

If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem via fiddle.tinymce.com or similar.
http://fiddle.tinymce.com/OBgaab

What is the expected behavior?
Each toolbar should be in a separate line

Which versions of TinyMCE, and which browser / OS are affected by this issue? Did this work in previous versions of TinyMCE?
TinyMCE 5+
I believe it's not browser/os related issue, but I am using macOS Mojave v10.14

It worked in TinyMCE 4.9.2 and below.

@TheSpyder

This comment has been minimized.

Copy link
Member

TheSpyder commented Feb 9, 2019

Oh this is embarrassing. The new toolbar design called for toolbars to wrap rather than allow multiple lines as in the previous design. What you're seeing is intentional; rather than drop toolbar(n) support completely we merge the configs into a single toolbar.

However it seems the task to update the documentation was incorrectly assigned and completely left out of the release, it's not in the migration guide and we also left the toolbar(n) documentation in place.

I'll make sure the documentation is updated next week, my sincere apologies. This was one of the changes we were wondering if we'd get community feedback on, we would like to hear about cases where multiple toolbars are used. It's not difficult to bring them back if we need to.

We are also working on a "more drawer" design which will enforce a single row toolbar with groups overflowing into a second toolbar that is hidden by default.

@ronfogel

This comment has been minimized.

Copy link
Author

ronfogel commented Feb 9, 2019

Well, my use case is as follows:
I wanted to have a separation between styling and rest (all the buttons that changes the style in one row, and all the other in a different row)
screen shot 2019-02-09 at 13 45 34

It's not that important for me, I dont mind having them in the same row, though I would prefer to have in a separate rows.

@WarwickGoatee

This comment has been minimized.

Copy link

WarwickGoatee commented Feb 22, 2019

Losing the option of multiple toolbars would be a problem for us - I'd very much support keeping it in as an option. Many people upgrading from 4 to 5 will end up with broken layouts as a result...

@guiligan

This comment has been minimized.

Copy link

guiligan commented Feb 24, 2019

We use 2/3 rows in our editor leaving our custom plugins' buttons in different rows, allowing our users to find their expected functionality faster and easier than if merged in a single line with all formating options.

@JerimSD

This comment has been minimized.

Copy link

JerimSD commented Mar 5, 2019

Hi, I thought it was a bug too.
We use different rows to separate functionalities exactly like @ronfogel
And just like @WarwickGoatee said upgrading from v4 to v5 has resulted in a broken layout for us.

@halfninja

This comment has been minimized.

Copy link

halfninja commented Mar 7, 2019

I think it would be fine to have this new behaviour by default, as long as you can provide an init option to allow us to go back to the old behaviour with multiple toolbars. There are many reasons why they are useful.

@TheSpyder is the documentation still due to be updated?

@TheSpyder

This comment has been minimized.

Copy link
Member

TheSpyder commented Mar 7, 2019

No, I logged it as a documentation ticket and it fell through the cracks in the lead-up to release.

This is one of the regression issues we are discussing internally. There has been enough requests for it that we are probably going to reimplement multiple toolbars. We haven't scheduled the work yet but we are thinking through the design considerations of this.

Sorry for not updating this ticket, I'll make an effort to do better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.