Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TinyMCE 4.9.3: Link list still content displays offscreen when window is small #4827

Open
cdaveb opened this Issue Feb 13, 2019 · 2 comments

Comments

Projects
None yet
3 participants
@cdaveb
Copy link

cdaveb commented Feb 13, 2019

I'm not sure what the appropriate protocol is for reporting that an issue still exists when it has been closed already. I added a comment to the initial report at #4624 , but in case closed issues are not reviewed I thought I should also add it as a new issue.

Do you want to request a feature or report a bug?
Bug

What is the current behavior?
When in a small window, the link_list feature when using long or nested nested menus does not correctly adjust the position of the menus to the edge of the browser window, so menu content flows outside the window and is not usable.

If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem via fiddle.tinymce.com or similar.

I've created an example here of the behavior:
https://codepen.io/cdaveb/pen/YJERby

To reproduce it, bring up the link window by selecting text and using the link option. Then scroll towards the bottom of the page. Open the link list and navigate the menus. You'll note that some of the menus appear cutoff by the edge of the page. This can be worked around if the window is large enough, but that's not an option for all users. Below is a screenshot of the behavior in question:

This is a screenshot of what I'm seeing:
tinymce_scrollsoffscreen

What is the expected behavior?

The expected behavior is for the menus to be displayed in a position that the entire menu can be seen or scrolled to, even when at the bottom of the screen or when the window is small.

Which versions of TinyMCE, and which browser / OS are affected by this issue? Did this work in previous versions of TinyMCE?

I can reproduce the issue reliably with a small browser window in TinyMCE 4.9.3, 4.9.2 and 4.9.1 in Chrome and Firefox on the Mac .

@cdaveb cdaveb changed the title Link list still content displays offscreen when window is small TinyMCE 4.9.3: Link list still content displays offscreen when window is small Feb 13, 2019

@TheSpyder

This comment has been minimized.

Copy link
Member

TheSpyder commented Feb 14, 2019

When you comment on a case, even a closed one, it notifies all participants (and anyone watching the project). You don't need to open a new ticket, I'll let @lnewson know he needs to take another look.

@TheSpyder TheSpyder closed this Feb 14, 2019

@lnewson

This comment has been minimized.

Copy link
Contributor

lnewson commented Feb 17, 2019

After looking at this more, this is actually a different issue to #4624 because the other was related to the scroll position and it not taking into account the bottom of the page when trying to position. This one however is about how listbox components are rendered on really small screens, where there isn't enough room to render the menu.

As such, I'm going to reopen this so that it can be investigated further. One possible solution maybe to make the menu scroll when there's not enough room to render it fully, but we'd have to look into that.

I also tried to reproduce this on v5, however v5 uses a new UI which doesn't use the old listbox component and currently doesn't support nested lists in the link_list setting: #4822. In saying that however, regular menu items appeared to work (ie collapses with scrollbar) so this might be a v4 specific bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.