Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unlink/Remove Link option does not activated when there are multiple links in selected texts. #5599

Closed
mostafa-K-raihan opened this issue Apr 24, 2020 · 5 comments · Fixed by #5853

Comments

@mostafa-K-raihan
Copy link

What is the current behavior? Describe the bug
If the editor contains multiple links inside a large texts, selecting all texts does not activate the remove link/unlink button. It only gets activated when a single link is selected. This feature was there in version < 5. We recently migrated to version 5 and lost the feature.

Please provide the steps to reproduce and if possible a minimal demo of the problem via fiddle.tinymce.com or similar.

  • write a large text with multiple links
  • select all text using ctrl + a
  • remove link / unlink will not be activated

What is the expected behavior?

  • remove link / unlink should be activated and work accordingly

Which versions of TinyMCE, and which browser / OS are affected by this issue? Did this work in previous versions of TinyMCE?
tried with tinymce v5, chrome 81 on macOS (Mojave)

@EkimChau
Copy link
Contributor

EkimChau commented Apr 24, 2020

Hi mostafa-K-raihan ,

"selecting all texts does not activate the remove link/unlink button" Do you mean the link button in the main toolbar? or the context menu?

I can't replicate the issue you are reporting as both TinyMCE 4 and TinyMCE 5 appear to behave the same way when i tested this.

Could you make a fiddle or screenshots of the replication for TinyMCE 4 and TinyMCE 5 that shows the problem?

@mostafa-K-raihan
Copy link
Author

Hi @EkimChau

<script type="text/javascript">
tinymce.init({
    selector: "textarea",
    plugins: [
        "link"
    ],
    toolbar: "link unlink"
});
</script>

<form method="post" action="dump.php">
    <textarea name="content"></textarea>
</form>

try this in both version 4 and 5, have multiple links in the text area. select all the text, you will notice the difference. lemme know if you need anything else !

@EkimChau
Copy link
Contributor

Hi mostafa-K-raihan,

I was able to replicate the issue you were seeing with the provided config. This is a regression and we have now added this to our bug backlog to be fixed.

Thank you for reporting the issue

@mostafa-K-raihan
Copy link
Author

@EkimChau thank you for your response. Any idea, how long do we have to wait for the fix ?

@lnewson
Copy link
Contributor

lnewson commented Sep 29, 2020

This issue has been fixed in TinyMCE 5.5.0, which was released to the community earlier today. Thanks again for reporting this and please let us know if you have any further issues.

@lnewson lnewson closed this as completed Sep 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants