Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zazu 0.6.0 #341

Merged
merged 128 commits into from Jun 18, 2019

Conversation

Projects
None yet
2 participants
@linonetwo
Copy link
Member

commented May 13, 2019

Latest electron contains Node version > 6, which can better supports some plugin (for example plugin that uses Wasm from sql.js)

Tested locally, functional properly, but seems lagging in dev build.

@linonetwo linonetwo referenced this pull request May 13, 2019

Closed

Better logs #342

@linonetwo

This comment has been minimized.

Copy link
Member Author

commented May 13, 2019

After this is merged, I'm going to fix some other issues.

But it becomes very slow after upgrade electron that many tests failed, I have to look into it.

@linonetwo

This comment has been minimized.

Copy link
Member Author

commented May 13, 2019

屏幕快照 2019-05-13 下午9 11 12

屏幕快照 2019-05-13 下午9 32 31

Logging is very slow in electron5, even before I upgrade winston.

And it's all on globalEmitter.emit('pluginLog'

屏幕快照 2019-05-13 下午9 34 50

@linonetwo

This comment has been minimized.

Copy link
Member Author

commented May 13, 2019

It's blazing fast because I only log when the debugger is opened.

But tests still failed, I'm confused.

@linonetwo

This comment has been minimized.

Copy link
Member Author

commented May 13, 2019

Good, seems only some plugin regression remains.

I will look into it next weekend. It's hard to debug, since I can't run tests locally due to octalmage/robotjs#483 . Considering replace robotjs with something actively maintained.

@linonetwo

This comment has been minimized.

Copy link
Member Author

commented May 14, 2019

After upgrading cucumber, all test passed in Windows and Linux.

Reason for OSX failed maybe that spectron is still on electron 3 electron-userland/spectron#358

And the reason of slow maybe catdad/raw-viewer#142
May need to change the usage of fs to adapt sandbox https://electronjs.org/blog/electron-5-0#automatic-modules-with-sandboxed-webcontents

@leejoramo-d51

This comment has been minimized.

Copy link

commented May 17, 2019

@linonetwo so glad you picked this project up!

@linonetwo

This comment has been minimized.

Copy link
Member Author

commented May 21, 2019

Reviewers don't have enough bandwidth for this recently, so I upload an upgraded version to baiducloud, only MacOS version:

https://pan.baidu.com/s/1aoScfago0PuGKJQtKYZEHQ password: krdd

And many plugins won't get an update recently, due to the lack of reviewer for PR. So I forked some of them and made them compatible for v0.6.0, here is my config file:

https://gist.github.com/linonetwo/c67997a192fd32df1211be5756c563e6

@linonetwo linonetwo changed the title Upgrade deps Zazu 0.6.0 Jun 18, 2019

@linonetwo linonetwo merged commit 582a553 into tinytacoteam:master Jun 18, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.