Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ssl-redirect-plugin] Support custom SSL port & cover SslRedirectPlugin with tests #1835

Merged
merged 2 commits into from Mar 4, 2023
Merged

[ssl-redirect-plugin] Support custom SSL port & cover SslRedirectPlugin with tests #1835

merged 2 commits into from Mar 4, 2023

Conversation

dzikoysk
Copy link
Member

@dzikoysk dzikoysk commented Mar 2, 2023

Resolves #1834

@tipsy
Copy link
Member

tipsy commented Mar 3, 2023

Thanks, I'll let @zugazagoitia review this one 😊

zugazagoitia
zugazagoitia approved these changes Mar 3, 2023
View reviewed changes
Copy link
Member

@zugazagoitia zugazagoitia left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! It should work with my connectors, but I can't try this until Monday since I'm traveling.

@tipsy
Copy link
Member

tipsy commented Mar 4, 2023

Thanks guys 🙌

@tipsy tipsy merged commit 7ce98ad into javalin:master Mar 4, 2023
9 checks passed
@dzikoysk dzikoysk deleted the gh-1834/custom-ssl-port branch March 4, 2023 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zugazagoitia zugazagoitia zugazagoitia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support custom SSL port in SslRedirectPlugin
3 participants
@dzikoysk @tipsy @zugazagoitia