Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐞 Bug Report: mini query window not fully display placeholder text #302

Closed
4 tasks done
phlpsong opened this issue Jan 4, 2024 · 2 comments
Closed
4 tasks done

🐞 Bug Report: mini query window not fully display placeholder text #302

phlpsong opened this issue Jan 4, 2024 · 2 comments
Assignees
@phlpsong
Labels
bug Something isn't working fixed in next release The issue will be closed once next release is available

Comments

@phlpsong
Copy link
Collaborator

phlpsong commented Jan 4, 2024

Please confirm the following:

  • I have carefully read the README
  • I have searched through the issues page but couldn't find a solution.(Including issue that has been closed)
  • Easydict has been upgraded to the latest version

Problem description

placeholder text is not fully displayed in the mini window

mini:
Screenshot 2024-01-04 at 12 49 43

Reproduction steps

Status bar menu icon, select Show Mini Window in pop menu

Screenshot

Screenshot 2024-01-04 at 12 49 52

Expected result

Show fully placeholder text

Proposed solution (optional)

increase the window width or text view lines.

Device type and OS version

MacOS 14.2.1, Easydict 2.4.1

Are you willing to submit a PR to fix this issue?

  • I'm willing to submit a PR
@phlpsong phlpsong added the bug Something isn't working label Jan 4, 2024
@tisfeng
Copy link
Owner

tisfeng commented Jan 4, 2024

行，那还是增加 mini 输入框高度，显示2行吧。

phlpsong added a commit to phlpsong/Easydict that referenced this issue Jan 4, 2024
@phlpsong
bugfix: tisfeng#302 placeholder text not fully display in mini window
06bd72f
@phlpsong phlpsong mentioned this issue Jan 4, 2024
Merged
tisfeng pushed a commit that referenced this issue Jan 4, 2024
@phlpsong
bugfix: #302 placeholder text not fully display in mini window (#303)
ecb83e5
@tisfeng tisfeng added the fixed in next release The issue will be closed once next release is available label Jan 4, 2024
@tisfeng
Copy link
Owner

tisfeng commented Jan 5, 2024

2.5.0 版本已修复该问题。

@tisfeng tisfeng closed this as completed Jan 5, 2024
tisfeng pushed a commit that referenced this issue Jan 6, 2024
@phlpsong @tisfeng
bugfix: #302 placeholder text not fully display in mini window (#303)
85b6069
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@phlpsong phlpsong

Labels
bug Something isn't working fixed in next release The issue will be closed once next release is available
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tisfeng @phlpsong