Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frequent sign-in prompts #198

Open
funblaster22 opened this issue Jan 10, 2023 · 2 comments
Open

Frequent sign-in prompts #198

funblaster22 opened this issue Jan 10, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@funblaster22
Copy link
Contributor

I'll take a look at this. It seems there might be logic missing to check if you're already logged-in, or not using refresh tokens

funblaster22 added a commit that referenced this issue Jan 12, 2023
@funblaster22 funblaster22 linked a pull request Jan 12, 2023 that will close this issue
@devksingh4
Copy link
Contributor

The refresh token functionality seems to be broken in react-native-google-auth. Please reopen the PR if you can validate it to be working now - it's possible its been fixed in new versions. It does work correctly on iOS usually. Tokens expire either every 60min or 90min, don't remember which. We had issues during last comp where an expired token would result in lost scouting data, so getting rid of that forced auth would require extensive testing.

If we implement this we also would need to implement a "Switch User" setting.

@devksingh4
Copy link
Contributor

You should be able to implement refresh tokens with this comment: react-native-google-signin/google-signin#425 (comment). So we would need to create an API route on TRA API to use the CLIENT_ID and CLIENT_SECRET that we would store on API to refresh the token. I believe I just didn't want to mess around with it before comp so if you can get it working that would be great, but I would call it medium priority.

@devksingh4 devksingh4 added the enhancement New feature or request label Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants