Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error in selecting range with large files. #59

Closed
1 task
anubhavmalik opened this issue Mar 23, 2019 · 2 comments
Closed
1 task

Error in selecting range with large files. #59

anubhavmalik opened this issue Mar 23, 2019 · 2 comments

Comments

@anubhavmalik
Copy link

  • I have verified there are no duplicate active or recent bugs, questions, or requests
Include the following:
  • k4l-video-trimmer version: 1.0.3
  • Device OS version: 5.1.1
  • Devide Manufacturer: Lenovo
  • Device Name: Vibe K5 Plus
Reproduction Steps
  1. SetMaxDuration as 30 seconds
  2. Choose a large sized video. Say 2 hours (A movie or something)
  3. Move the range seek bar to ends of the movie, the max duration will increase and not remain 30 seconds (visually).
Expected Result

A trimmed file of 30 seconds duration

Actual Result

A trimmed file of 2 - 3 minutes

Tell us what could be improved:
@anubhavmalik
Copy link
Author

I have fixed the issue and forced the duration at setMax length. Will probably create a PR sometime in the future.

@aashitshah26
Copy link

Hey what changes have you done ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@anubhavmalik @aashitshah26