Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should the input to the include_top ignore the input to the last denseblock? #23

Closed
jrwin opened this issue Sep 7, 2017 · 5 comments
Closed

Comments

@jrwin
Copy link

jrwin commented Sep 7, 2017

In the densenet FCN paper, the Diagram of Figure1 show no skip connection from input to output of the last denseblock in the decompression path.
But the function '__create_fcn_dense_net' use the skip connection like:
line 770 of densenet.py
x = Conv2D(nb_classes, (1, 1), activation='linear', padding='same', use_bias=False)(x_up)

Dose I mis-understand it? Or this operation is an improved one that I miss?

@titu1994
Copy link
Owner

titu1994 commented Sep 7, 2017

Thats not a skip connection. That is a pixel wise classification layer (where each pixel will be convolved over using a point wise convolution operation to classify that pixel).

@titu1994 titu1994 closed this as completed Sep 7, 2017
@jrwin
Copy link
Author

jrwin commented Sep 7, 2017

I mean the input of the pixel wise classification layer, so call 'x_up', concatenate the input of its corresponding denseblock. It is different from the paper, where the input to the classification layer should not concatenate the input of the denseblock. And following your code, it should be:
l = concatenate(concat_list[1:], axis=concat_axis)
Just like input to others denseblock.

So I think I may miss something. Could you give me some guidance?

@titu1994 titu1994 reopened this Sep 7, 2017
@titu1994
Copy link
Owner

titu1994 commented Sep 7, 2017

See the last portion. I can't find the mistake, and since it has the exact same number of parameters as the paper (9.4 million), I can't seem to guess where the error is.

test

@jrwin
Copy link
Author

jrwin commented Sep 7, 2017

The parameter is similar to the paper's.
And the diagram of your model-plot seems to be like the attachment.
The diagram in the Figure 1 of the paper did not have the skip connection in the decompression path.
so I think there may be misunderstanding.

new microsoft visio drawing

@titu1994
Copy link
Owner

titu1994 commented Sep 7, 2017

I'll look into it. If you can figure out of where to correct it, please submit a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants