Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @kapoorlakshya (again! 😄),
Thanks for working on this! ❤️
However, while maintaining this in Debian, we found that this library relies on
git
to list the files which could be done via pure Ruby alternative -- which is what this PR does.As an addition, this PR makes sure that this gem only ships the required files to the end-users and not other things which are not needed by them! 🚀
Also, added rubocop-packaging as a development_dependency which will ensure the best practices.
Here's what it showed us:
And this PR fixes the same, which helps us in shipping this in Debian! 🎉
Hope this would make sense and you'll be open to this change 💯
Signed-off-by: Utkarsh Gupta <utkarsh@debian.org>