Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup outputs a JSON file per bundle, but all contents are identical #485

Closed
tivac opened this issue Aug 20, 2018 · 1 comment

Comments

Projects
None yet
1 participant
@tivac
Copy link
Owner

commented Aug 20, 2018

When enabling the json option for modular-css-rollup & using rollup's code-splitting support it'll output a .json file alongside every .js file, which is fine. What is less fine is that every single JSON file contains every single CSS file's output from across all the bundles.

Instead it should either A) output multiple files that only contain output from the files in each bundle or B) output a single JSON file containing everything.

Being able to choose between the two would be aces, frankly.

@tivac tivac self-assigned this Aug 20, 2018

tivac added a commit that referenced this issue Aug 25, 2018

feat: Named json output
Also fixes #485 by limiting output to a single file containing ALL compositions.

BREAKING CHANGE: The default file name when `json : true` has changed from whatever the CSS file was called to `exports.json`.

@tivac tivac closed this in #509 Aug 25, 2018

tivac added a commit that referenced this issue Aug 25, 2018

feat: Named json output (#509)
Also fixes #485 by limiting output to a single file containing ALL compositions.

BREAKING CHANGE: The default file name when `json : true` has changed from whatever the CSS file was called to `exports.json`
@tivac

This comment has been minimized.

Copy link
Owner Author

commented Aug 28, 2018

🎉📦🎉 Released in v15.0.0!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.