Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chunk dependency graph doesn't support circular dependencies #539

Closed
tivac opened this issue Jan 17, 2019 · 0 comments

Comments

Projects
None yet
1 participant
@tivac
Copy link
Owner

commented Jan 17, 2019

Expected Behavior

Chunks with circular dependencies between chunks are supported by rollup, and they should also be suppored by the @modular-css/rollup plugin.

Current Behavior

It throws a circular dependency error.

Possible Solution

new DepGraph({ circular : true }) should fix it.

Steps to Reproduce (for bugs)

  1. Set up a project with dynamic imports that have circular dependencies using @modular-css/rollup
  2. Run a build

Context

Can't run any builds since they error out every time.

Your Environment

Executable Version
modular-css 20.0.1
npm --version 6.5.0
node --version 10.12.0
OS Version
Windows 10 1607

@tivac tivac self-assigned this Jan 17, 2019

tivac added a commit that referenced this issue Jan 18, 2019

@tivac tivac referenced this issue Jan 18, 2019

Merged

Support circular dependencies #541

5 of 9 tasks complete

@tivac tivac closed this in #541 Jan 18, 2019

tivac added a commit that referenced this issue Jan 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.