Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

true-case-path is slowing down builds, try async #581

Closed
Ryan-McMillan opened this issue May 6, 2019 · 1 comment

Comments

Projects
None yet
2 participants
@Ryan-McMillan
Copy link

commented May 6, 2019

In lib/normalize.js, true-case-path appears to be adding a lot of time to builds. We discussed exploring if the async version of this helps.

Build times decrease significantly when bypassing true-case-path 馃帀
first time: 15s -> 10s
incremental builds: 3.3s -> 2.2s

| modular-css/rollup | 23.0.6 |
| modular-css/processor | 23.0.4 |
| npm --version | 6.9.0 |
| node --version | 10.15.3 |

| Windows | 10 |

@tivac tivac self-assigned this May 7, 2019

@tivac tivac added bug pkg:core labels May 7, 2019

@tivac

This comment has been minimized.

Copy link
Owner

commented May 7, 2019

Removing this and adding a warning instead in this branch

@tivac tivac referenced this issue May 7, 2019

Merged

Remove true-case-path #582

7 of 9 tasks complete

@tivac tivac closed this in #582 May 8, 2019

tivac added a commit that referenced this issue May 8, 2019

refactor(processor): add dupewarn option and no longer resolve path c鈥
鈥se (#582)

BREAKING CHANGE:

It was causing massive slowdowns to synchronously resolve files using `true-case-path`, and making it async wasn't a guaranteed win either. So it's removed, which should solve #581 pretty neatly.

Instead now there's a warning if two files are included that differ in case only. It can be disabled by setting `dupewarn : false` as part of the config object.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.