Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add rewrite option #368

Merged
merged 6 commits into from Nov 15, 2017
Merged

feat: add rewrite option #368

merged 6 commits into from Nov 15, 2017

Conversation

@tivac
Copy link
Owner

@tivac tivac commented Nov 14, 2017

So that the postcss-url functionality is configurable and can be disabled in a less surprising way.

// postcss-url disabled
var processor = new Processor({ rewrite : false });

// Passing options to postcss-url
var processor = new Processor({
    rewrite : {
        url : "inline"
    }
});

Still needed:

  • Docs
  • Expose as CLI flag so rewriting can be disabled from CLI
  • Changelog entry

⚠️ This will require a major version bump, because passing after : [] will no longer prevent postcss-url from running ⚠️

So that the `postcss-url` functionality is configurable and can be disabled in a less surprising way.
@tivac tivac merged commit 613abb8 into master Nov 15, 2017
2 checks passed
Loading
@tivac tivac deleted the rewrite-option branch Nov 15, 2017
tivac added a commit that referenced this issue Nov 16, 2017
So that the `postcss-url` functionality is configurable and can be disabled in a less surprising way.

BREAKING CHANGE: To prevent `postcss-url` from running you now specify `rewrite: false` instead of defining an `after` segment.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant