Allow plugin exports via "processing" lifecycle hook #404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`after` should probably just become what `during` is, it's a breaking change but not terribly different in practice. Plugins run as part of the `during` phase can add messages with a plugin name starting with `modular-css-export` and an `exports` key that will be merged into the file's exports. Fixes #401 in a roundabout way by making it possible w/o a change to core. This also makes the output module support non-array values because having to know that is just an awkward implementation detail that makes no sense for anyone but me.
It's at least a little better
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on a request from @AndrewLeedham in #401, this new lifecycle hook allows for modifying the exports of a CSS file by pushing a specifically crafted message onto the messages array. Details are in the new extending.md document which also conveniently exists now to better document lifecycle hooks and what they're good for.
Planning on shipping this for
8.1.0unless someone really hates the name and lets me know pretty quickly, it's a pretty harmless change that could allow some interesting new approaches.