Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: webpack inline maps should work #406

Merged
merged 1 commit into from Feb 21, 2018

Conversation

Projects
None yet
2 participants
@tivac
Copy link
Owner

commented Feb 21, 2018

Somehow this was never tested before?

Also make sure that errors from the plugin propagate correctly.

This fixes an error that @chiel and @getkey reported in gitter.

fix: webpack inline maps should work
Somehow this was never tested before?

Also make sure that errors from the plugin propagate correctly.

@tivac tivac self-assigned this Feb 21, 2018

@tivac

This comment has been minimized.

Copy link
Owner Author

commented Feb 21, 2018

PR build failing appears to be webpack ordering weirdness, which I have a long-term plan to hopefully solve using the recordsPath option.

@tivac tivac merged commit f396866 into master Feb 21, 2018

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@tivac tivac deleted the webpack-map-errors branch Feb 21, 2018

@getkey

This comment has been minimized.

Copy link
Contributor

commented Feb 22, 2018

Awesome! Thanks @tivac

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.