Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: webpack 4 #413

Merged
merged 2 commits into from Mar 8, 2018

Conversation

Projects
None yet
3 participants
@getkey
Copy link
Contributor

commented Mar 6, 2018

This PR fixes API changes introduced in Webpack 4.

@tivac

This comment has been minimized.

Copy link
Owner

commented Mar 6, 2018

@getkey Thanks! Is this actually testing against webpack@4?

@getkey

This comment has been minimized.

Copy link
Contributor Author

commented Mar 6, 2018

Right, I forgot to run the tests. I also need to update the devDependency. I'll do it tomorrow because I'm in bed now. ;-)

@getkey

This comment has been minimized.

Copy link
Contributor Author

commented Mar 7, 2018

A bunch of tests are failing because webpack@4 prepends ./dist/ to the output path.

@tivac

This comment has been minimized.

Copy link
Owner

commented Mar 7, 2018

Neat, I'll take a look when I get into the office in a bit. May just need to tweak the test webpack configs, hopefully.

@tivac

This comment has been minimized.

Copy link
Owner

commented Mar 7, 2018

Most of the failures seem to be around webpack@4 defaulting to production mode. I'm working on finalizing the test cleanup in a branch that I'll merge manually.

https://github.com/tivac/modular-css/tree/pr/413

Having some weird output from the test that runs webpack multiple times w/ changed file contents though, will need to investigate that further I think.

@tivac

This comment has been minimized.

Copy link
Owner

commented Mar 7, 2018

Looks like compiler.plugin("invalid") is no longer triggering, so my plugin happily barfs out the cached contents forever.

😒

I'll need to do some research on what replaced that event. I love major version upgrades!

@deflock

This comment has been minimized.

Copy link

commented Mar 7, 2018

@tivac

This comment has been minimized.

Copy link
Owner

commented Mar 7, 2018

@deflock I tried that, it never seems to get invoked either. 😒

@tivac

This comment has been minimized.

Copy link
Owner

commented Mar 8, 2018

Tracked it down, fixing the last few Travis failures now.

@tivac tivac merged commit 9c03206 into tivac:master Mar 8, 2018

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details

tivac added a commit that referenced this pull request Mar 8, 2018

fix: webpack tests (#414)
#413 got things working, now the tests pass too!

tivac added a commit that referenced this pull request Mar 8, 2018

tivac added a commit that referenced this pull request Mar 8, 2018

fix: webpack tests (#414)
#413 got things working, now the tests pass too!
@tivac

This comment has been minimized.

Copy link
Owner

commented Mar 8, 2018

@getkey published as modular-css-webpack@8.2.0

Thanks again! 🎉

@getkey

This comment has been minimized.

Copy link
Contributor Author

commented Mar 8, 2018

Awesome, thanks @tivac!

If I understand correctly #409, support for Webpack 2 & 3 is dropped for the moment, right?

@getkey getkey deleted the getkey:webpack-4-fix branch Mar 8, 2018

@tivac

This comment has been minimized.

Copy link
Owner

commented Mar 8, 2018

AFAIK this version should be compatible with webpack 2-4, though testing it against multiple versions is challenge.

@getkey

This comment has been minimized.

Copy link
Contributor Author

commented Mar 8, 2018

Ah alright, yes! 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.