Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests for #413 #414

Merged
merged 5 commits into from Mar 8, 2018

Conversation

Projects
None yet
1 participant
@tivac
Copy link
Owner

commented Mar 8, 2018

Required a bit of sleuthing, but I think we're good now!

@tivac tivac self-assigned this Mar 8, 2018

tivac added some commits Mar 7, 2018

test: clean up file changing test
Though it fails because `compiler.plugin("invalid")` isn't firing any more...
fix: Maps aren't Objects
INTERESTING FACT

@tivac tivac force-pushed the pr/413 branch from 3b1a176 to db04235 Mar 8, 2018

@tivac tivac merged commit 2e63c78 into master Mar 8, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@tivac tivac deleted the pr/413 branch Mar 8, 2018

tivac added a commit that referenced this pull request Mar 8, 2018

fix: webpack tests (#414)
#413 got things working, now the tests pass too!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.