Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for Rollup 60 #429

Merged
merged 9 commits into from Jun 7, 2018

Conversation

Projects
None yet
1 participant
@tivac
Copy link
Owner

commented Jun 7, 2018

This takes advantage of the new plugins APIs introduced in rollup/rollup#2208

modular-css-rollup will now support automatic chunks via multiple inputs and manual chunking of vendor files via manualChunks. It might also support dynamic import but I haven't written tests for that yet.

This is a ⚠️ BREAKING CHANGE ⚠️, it will only be compatible with rollup@0.60 and higher.

tivac added some commits Jun 6, 2018

feat: basic rollup@0.60.0
Doesn't include code-splitting **YET**. But I'm planning on it!
feat: support basic bundle splitting
Still need to figure out manual chunks stuff I suppose?

Fixes #428
test: add manualChunks test
Also no longer outputting bogus empty files

@tivac tivac self-assigned this Jun 7, 2018

@codecov

This comment has been minimized.

Copy link

commented Jun 7, 2018

Codecov Report

Merging #429 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #429   +/-   ##
======================================
  Coverage    99.1%   99.1%           
======================================
  Files          35      36    +1     
  Lines         779     779           
  Branches      114     113    -1     
======================================
  Hits          772     772           
  Misses          7       7
Impacted Files Coverage Δ
packages/test-utils/exists.js 100% <100%> (ø)
packages/rollup/rollup.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 108da8d...cb98aeb. Read the comment docs.

@tivac tivac merged commit f731e9b into master Jun 7, 2018

4 checks passed

codecov/patch 100% of diff hit (target 99.1%)
Details
codecov/project 99.1% (+0%) compared to 108da8d
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@tivac tivac deleted the rollup-60 branch Jun 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.