Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rollup transform dependencies support #438

Merged
merged 13 commits into from Jun 26, 2018

Conversation

Projects
None yet
1 participant
@tivac
Copy link
Owner

commented Jun 25, 2018

https://github.com/rollup/rollup/blob/master/CHANGELOG.md#0610

Also a bunch of various rollup output cleanup bits.

@tivac tivac added the pkg:rollup label Jun 25, 2018

@tivac tivac self-assigned this Jun 25, 2018

tivac added some commits Jun 11, 2018

feat: use new rollup dependencies support
Tests are failing due to the `TODO`, can't get a filename until the file has a source but I need to know the filename when generating the source?
test: better test for dependency logic
The `bundle` param in `generateBundle` hook doesn't list the `transform`-added dependencies in the bundles so they never get output and the tests fail.
feat: working on correct bundling
Need to investigate the whole "dependency is invalidated" flow because that seems wrong atm.
fix: output ALL the css
- Make `common` be "common.css" by default so css doesn't get lost.
- Reworked bundle algorithms to do the work to count CSS file references and get them into the right bundles
- Updated for new `transform` behavior when changing a dependency.
test: try to keep jest from crashing
It didn't work though, still explodes in watch mode ALL THE TIME

@tivac tivac force-pushed the transform-dependencies branch from 817d366 to 152b181 Jun 26, 2018

@codecov

This comment has been minimized.

Copy link

commented Jun 26, 2018

Codecov Report

❗️ No coverage uploaded for pull request base (master@4afe3af). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #438   +/-   ##
=========================================
  Coverage          ?   99.09%           
=========================================
  Files             ?       31           
  Lines             ?      777           
  Branches          ?      119           
=========================================
  Hits              ?      770           
  Misses            ?        7           
  Partials          ?        0
Impacted Files Coverage Δ
packages/rollup/rollup.js 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4afe3af...152b181. Read the comment docs.

@tivac tivac merged commit 7347d8f into master Jun 26, 2018

4 checks passed

codecov/patch No report found to compare against
Details
codecov/project No report found to compare against
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@tivac tivac deleted the transform-dependencies branch Jun 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.