Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rollup transform dependencies support #438

Merged
merged 13 commits into from Jun 26, 2018
Merged

Add rollup transform dependencies support #438

merged 13 commits into from Jun 26, 2018

Conversation

@tivac
Copy link
Owner

@tivac tivac commented Jun 25, 2018

https://github.com/rollup/rollup/blob/master/CHANGELOG.md#0610

Also a bunch of various rollup output cleanup bits.

@tivac tivac self-assigned this Jun 25, 2018
tivac added 13 commits Jun 26, 2018
Tests are failing due to the `TODO`, can't get a filename until the file has a source but I need to know the filename when generating the source?
The `bundle` param in `generateBundle` hook doesn't list the `transform`-added dependencies in the bundles so they never get output and the tests fail.
Need to investigate the whole "dependency is invalidated" flow because that seems wrong atm.
- Make `common` be "common.css" by default so css doesn't get lost.
- Reworked bundle algorithms to do the work to count CSS file references and get them into the right bundles
- Updated for new `transform` behavior when changing a dependency.
It didn't work though, still explodes in watch mode ALL THE TIME
@tivac tivac force-pushed the transform-dependencies branch from 817d366 to 152b181 Jun 26, 2018
@codecov
Copy link

@codecov codecov bot commented Jun 26, 2018

Codecov Report

No coverage uploaded for pull request base (master@4afe3af). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #438   +/-   ##
=========================================
  Coverage          ?   99.09%           
=========================================
  Files             ?       31           
  Lines             ?      777           
  Branches          ?      119           
=========================================
  Hits              ?      770           
  Misses            ?        7           
  Partials          ?        0
Impacted Files Coverage Δ
packages/rollup/rollup.js 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4afe3af...152b181. Read the comment docs.

Loading

@tivac tivac merged commit 7347d8f into master Jun 26, 2018
4 checks passed
Loading
@tivac tivac deleted the transform-dependencies branch Jun 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant