Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: emit warnings on missing keys #445

Merged
merged 1 commit into from Jul 11, 2018

Conversation

Projects
None yet
1 participant
@tivac
Copy link
Owner

commented Jul 11, 2018

Also adds strict mode which will throw errors on missing keys.

feat: emit warnings on missing keys
Also adds strict mode which will throw errors on missing keys.

@tivac tivac self-assigned this Jul 11, 2018

@tivac tivac merged commit 9cc656b into master Jul 11, 2018

4 checks passed

codecov/patch 100% of diff hit (target 99.1%)
Details
codecov/project 99.11% (+0.01%) compared to 5facdff
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@tivac tivac deleted the svelte-warnings branch Jul 11, 2018

@codecov

This comment has been minimized.

Copy link

commented Jul 11, 2018

Codecov Report

Merging #445 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #445      +/-   ##
==========================================
+ Coverage    99.1%   99.11%   +0.01%     
==========================================
  Files          31       31              
  Lines         778      789      +11     
  Branches      119      121       +2     
==========================================
+ Hits          771      782      +11     
  Misses          7        7
Impacted Files Coverage Δ
packages/svelte/src/markup.js 100% <100%> (ø) ⬆️
packages/svelte/svelte.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5facdff...ef14e23. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.