Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: tighten up rollup bundles #450

Merged
merged 2 commits into from Jul 13, 2018

Conversation

Projects
None yet
1 participant
@tivac
Copy link
Owner

commented Jul 13, 2018

When working on #449 I got annoyed at how many times I was having to check common.css in cases where it wasn't actually necessary.

So now I've done something about it. modular-css-rollup will only create a common.css if there's more than one CSS bundle being generated which is how it should've been all along.

@tivac tivac self-assigned this Jul 13, 2018

@codecov

This comment has been minimized.

Copy link

commented Jul 13, 2018

Codecov Report

Merging #450 into master will decrease coverage by 0.12%.
The diff coverage is 93.75%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #450      +/-   ##
========================================
- Coverage   99.12%    99%   -0.13%     
========================================
  Files          31     31              
  Lines         798    800       +2     
  Branches      123    124       +1     
========================================
+ Hits          791    792       +1     
- Misses          7      8       +1
Impacted Files Coverage Δ
packages/rollup/rollup.js 98.73% <93.75%> (-1.27%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d83e3c...2ebb6e1. Read the comment docs.

@tivac tivac merged commit 9febe9f into master Jul 13, 2018

2 of 4 checks passed

codecov/patch 93.75% of diff hit (target 99.12%)
Details
codecov/project 99% (-0.13%) compared to 1d83e3c
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@tivac tivac deleted the rollup-bundle-tightening branch Jul 13, 2018

tivac added a commit that referenced this pull request Jul 13, 2018

fix: tighten up rollup bundles (#450)
BREAKING CHANGE: Common chunks will only be created if necessary now.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.