Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: External map references #457

Merged
merged 2 commits into from Jul 19, 2018

Conversation

Projects
None yet
1 participant
@tivac
Copy link
Owner

commented Jul 19, 2018

Fixes #455

This won't handle [hash] but I have no idea what I could possibly do there in that instance, because rollup won't tell me the filename ahead of time (since it can't get the hash until it has the contents, an annoying 馃悢 and 馃 problem).

@tivac tivac self-assigned this Jul 19, 2018

tivac added some commits Jul 18, 2018

fix: replace placeholders in assetFileNames
So that external source map references point to the right file. Gotta pass a real file to postcss or it does some funny things.

Fixes #455

@tivac tivac force-pushed the external-map-references branch from 082a9d6 to a769269 Jul 19, 2018

@codecov

This comment has been minimized.

Copy link

commented Jul 19, 2018

Codecov Report

Merging #457 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #457      +/-   ##
==========================================
+ Coverage   99.01%   99.01%   +<.01%     
==========================================
  Files          31       31              
  Lines         810      815       +5     
  Branches      128      129       +1     
==========================================
+ Hits          802      807       +5     
  Misses          8        8
Impacted Files Coverage 螖
packages/rollup/rollup.js 98.92% <100%> (+0.06%) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update d459beb...a769269. Read the comment docs.

Repository owner deleted a comment from TravisBuddy Jul 19, 2018

@tivac tivac merged commit 2d3257e into master Jul 19, 2018

4 checks passed

codecov/patch 100% of diff hit (target 99.01%)
Details
codecov/project 99.01% (+<.01%) compared to d459beb
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@tivac tivac deleted the external-map-references branch Jul 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.