Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove files when re-preprocessing for svelte #463

merged 4 commits into from Aug 1, 2018


None yet
1 participant
Copy link

commented Aug 1, 2018

Fixes #462 by ensuring that in cases where the same preprocess is run against a file multiple times (like when using modular-css-svelte with modular-css-rollup in --watch mode) it'll pick up any changes w/o having to restart the watcher.

tivac added some commits Aug 1, 2018

test: failing test for svelte reprocessing
This can occur when using modular-css-svelte and modular-css-rollup together in rollup's watch mode.

@tivac tivac self-assigned this Aug 1, 2018


This comment has been minimized.

Copy link

commented Aug 1, 2018

Codecov Report

Merging #463 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #463      +/-   ##
+ Coverage   99.02%   99.02%   +<.01%     
  Files          31       31              
  Lines         818      819       +1     
  Branches      130      131       +1     
+ Hits          810      811       +1     
  Misses          8        8
Impacted Files Coverage Δ
packages/svelte/src/markup.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a45117b...6eaeff8. Read the comment docs.

@tivac tivac merged commit 113cfa1 into master Aug 1, 2018

4 checks passed

codecov/patch 100% of diff hit (target 99.02%)
codecov/project 99.02% (+<.01%) compared to a45117b
continuous-integration/travis-ci/pr The Travis CI build passed
continuous-integration/travis-ci/push The Travis CI build passed

@tivac tivac deleted the svelte-deleting branch Aug 1, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.