Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bundle specific ref-counting #467

Merged
merged 2 commits into from Aug 10, 2018

Conversation

Projects
None yet
1 participant
@tivac
Copy link
Owner

commented Aug 10, 2018

Previously ref-counting for CSS file usage was just an incrementing number. This could lead to issues like #466 where a CSS file is incorrectly promoted to common.css because it is referenced in multiple places within a single bundle.

The new logic checks the number of bundles the CSS file appears in, and only puts the file into common.css if it's in more than one bundle.

@tivac tivac self-assigned this Aug 10, 2018

@codecov

This comment has been minimized.

Copy link

commented Aug 10, 2018

Codecov Report

Merging #467 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #467   +/-   ##
=======================================
  Coverage   98.91%   98.91%           
=======================================
  Files          31       31           
  Lines         831      831           
  Branches      134      133    -1     
=======================================
  Hits          822      822           
  Misses          9        9
Impacted Files Coverage Δ
packages/rollup/rollup.js 97.95% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a1c878...d849f89. Read the comment docs.

@tivac tivac merged commit 3d38d46 into master Aug 10, 2018

4 checks passed

codecov/patch 100% of diff hit (target 98.91%)
Details
codecov/project 98.91% (+0%) compared to 1a1c878
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@tivac tivac deleted the more-chunking branch Aug 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.