Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: run after plugins against files serially #508

merged 12 commits into from Aug 25, 2018


None yet
1 participant
Copy link

commented Aug 25, 2018

Fixes #503

This ended up also including some modern ES conversions in files that I happened to have open as well as some fixes for package update snafus that had occurred. I also updated a few more packages, because why not?

So not the most targeted PR but hey, things happen.

BREAKING CHANGE: Processors must now be instantiated via new

tivac added some commits Aug 25, 2018

chore: remove cssnano tests
It depends on `postcss-selector-parser@2` which is breaking everything when I try to run tests because I need at least v3.
feat: run afters serially
Also ES6-ified including `class`.

BREAKING CHANGE: Processor must be instantiated with new, it is no longer auto-instantiating.
chore: add outdated task
Since I can't depend on greenkeeper or renovate bot any more I guess.

@tivac tivac self-assigned this Aug 25, 2018


This comment has been minimized.

Copy link

commented Aug 25, 2018

Codecov Report

Merging #508 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #508      +/-   ##
- Coverage   98.91%   98.91%   -0.01%     
  Files          31       31              
  Lines         831      829       -2     
  Branches      133      130       -3     
- Hits          822      820       -2     
  Misses          9        9
Impacted Files Coverage Δ
packages/core/plugins/scoping.js 100% <100%> (ø) ⬆️
packages/core/processor.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e92795f...9c58cc1. Read the comment docs.

@tivac tivac merged commit 14bae1d into master Aug 25, 2018

4 of 5 checks passed

deploy/netlify Deploy preview failed.
codecov/patch 100% of diff hit (target 98.91%)
codecov/project Absolute coverage decreased by -<.01% but relative coverage increased by +1.08% compared to e92795f
continuous-integration/travis-ci/pr The Travis CI build passed
continuous-integration/travis-ci/push The Travis CI build passed

@tivac tivac deleted the serial-afters branch Aug 25, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.