Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use rollup@0.65.0's watchChange event #511

Merged
merged 4 commits into from Aug 28, 2018

Conversation

Projects
None yet
1 participant
@tivac
Copy link
Owner

commented Aug 28, 2018

I requested it in rollup/rollup#2383, @guybedford added it in rollup/rollup#2405, and now I get to delete a bunch of complicated code!

馃帀馃憦馃徎馃帀 @guybedford 馃帀馃憦馃徎馃帀

tivac added some commits Aug 28, 2018

feat: use rollup watchChange hook
Allows me to delete an AWFUL LOT OF code, which rules!
docs: call out minimum rollup version support
Also now in `peerDependencies` key, but this is important to document.

@tivac tivac self-assigned this Aug 28, 2018

@codecov

This comment has been minimized.

Copy link

commented Aug 28, 2018

Codecov Report

鉂楋笍 No coverage uploaded for pull request base (master@fd9d4f0). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #511   +/-   ##
=========================================
  Coverage          ?   98.89%           
=========================================
  Files             ?       31           
  Lines             ?      815           
  Branches          ?      128           
=========================================
  Hits              ?      806           
  Misses            ?        9           
  Partials          ?        0
Impacted Files Coverage 螖
packages/rollup/rollup.js 98.82% <100%> (酶)

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update fd9d4f0...361c12b. Read the comment docs.

@tivac tivac merged commit 510b662 into master Aug 28, 2018

4 of 5 checks passed

deploy/netlify Deploy preview failed.
Details
codecov/patch No report found to compare against
Details
codecov/project No report found to compare against
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@tivac tivac deleted the rollup-watchchange branch Aug 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.