Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: dev mode for rollup #518

merged 4 commits into from Sep 21, 2018


None yet
1 participant
Copy link

commented Sep 21, 2018

Fixes #516 (for rollup at least, more bundlers later if folks want 'em!)

This adds a new option to @modular-css/rollup, dev. Enabling dev mode will make the default exports of each CSS file a JS Proxy that throws whenever a non-existent property is read. Should be much easier to spot the VERY LOUD REFERENCE ERRORS vs trying to find instances of class="undefined", right?

That's the theory anyways!

This also fixes the rollup peerDependency so it stops complaining about rollup 0.66.0 and up.

tivac added some commits Sep 20, 2018

WIP: clean up output
Also fixed peer dependency for rollup

@tivac tivac self-assigned this Sep 21, 2018


This comment has been minimized.

Copy link

commented Sep 21, 2018

Codecov Report

Merging #518 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #518      +/-   ##
+ Coverage   98.84%   98.84%   +<.01%     
  Files          39       39              
  Lines         867      869       +2     
  Branches      131      131              
+ Hits          857      859       +2     
  Misses         10       10
Impacted Files Coverage Δ
packages/rollup/rollup.js 98.85% <100%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 18c157a...85e68bf. Read the comment docs.

@tivac tivac merged commit 979e26d into master Sep 21, 2018

4 of 5 checks passed

deploy/netlify Deploy preview failed.
codecov/patch 100% of diff hit (target 98.84%)
codecov/project 98.84% (+<.01%) compared to 18c157a
continuous-integration/travis-ci/pr The Travis CI build passed
continuous-integration/travis-ci/push The Travis CI build passed

@tivac tivac deleted the rollup-proxy branch Sep 21, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.