Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add verbose option to rollup & svelte #521

Merged
merged 4 commits into from Oct 12, 2018

Conversation

Projects
None yet
1 participant
@tivac
Copy link
Owner

commented Oct 12, 2018

Add new verbose option to rollup & svelte packages, also adds tests for the existing verbose option to processor package.

Fixes #520, though without using npmlog because it's more complicated than I need right now.

@codecov

This comment has been minimized.

Copy link

commented Oct 12, 2018

Codecov Report

Merging #521 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #521      +/-   ##
==========================================
+ Coverage   98.84%   98.87%   +0.02%     
==========================================
  Files          39       40       +1     
  Lines         869      890      +21     
  Branches      131      134       +3     
==========================================
+ Hits          859      880      +21     
  Misses         10       10
Impacted Files Coverage Δ
packages/svelte/svelte.js 100% <ø> (ø) ⬆️
packages/processor/processor.js 100% <100%> (ø) ⬆️
packages/svelte/src/markup.js 100% <100%> (ø) ⬆️
packages/test-utils/logs.js 100% <100%> (ø)
packages/rollup/rollup.js 98.94% <100%> (+0.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 64e8e15...0596cd4. Read the comment docs.

@tivac tivac merged commit 0706e3d into master Oct 12, 2018

4 checks passed

codecov/patch 100% of diff hit (target 98.84%)
Details
codecov/project 98.87% (+0.02%) compared to 64e8e15
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@tivac tivac deleted the logging branch Oct 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.