Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Rework svelte for race-condition fix #524

Merged
merged 1 commit into from Oct 24, 2018
Merged

feat: Rework svelte for race-condition fix #524

merged 1 commit into from Oct 24, 2018

Conversation

@tivac
Copy link
Owner

@tivac tivac commented Oct 24, 2018

@modular-css/svelte@17.0.0 was a big refactor into a class, but that introduced a race condition the tests didn't catch.

I haven't been able to repro the race condition w/ the actual tests, but reworking things this way fixes the issue at the cost of a GIANT FUNCTION. Worthwhile tradeoff, IMO.

I also took this opportunity to clean up some of the logging and make the output of injecting an import into a <script> look a bit nicer by not horking up the existing indentation.

@tivac tivac self-assigned this Oct 24, 2018
@tivac tivac merged commit 9d465db into master Oct 24, 2018
3 of 4 checks passed
Loading
@tivac tivac deleted the svelte-rework-again branch Oct 24, 2018
Repository owner deleted a comment from TravisBuddy Oct 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant