Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Path casing #528

merged 9 commits into from Nov 20, 2018


None yet
2 participants
Copy link

commented Nov 19, 2018

Standardize how incoming file paths are normalized (including case) to avoid cases where users can easily foot-gun themselves on case-insensitive filesystems.

This doesn't handle the same stuff that graph-tiers.js does where it ensures that all the files are actually unique & not symlinks or something, I need to move that logic into processor._add() as well eventually.

Fixes #527

tivac added some commits Nov 17, 2018

WIP: Bring back previous code
I went down a bad path.
WIP: remove processor-level casing test
The rollup version should be good enough.
WIP: rework processor
Moved logic from `.string()` to `._add()` so that it can be shared with `.file()`, and extra calls to `._normalize()` can be avoided.

Also updated some of the verbose output, so lots of snapshot changes.

@tivac tivac self-assigned this Nov 19, 2018


This comment has been minimized.

Copy link

commented Nov 19, 2018

Codecov Report

Merging #528 into master will increase coverage by 0.11%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #528      +/-   ##
+ Coverage   98.87%   98.99%   +0.11%     
  Files          38       39       +1     
  Lines         890      894       +4     
  Branches      139      138       -1     
+ Hits          880      885       +5     
+ Misses         10        9       -1
Impacted Files Coverage Δ
packages/processor/processor.js 100% <100%> (ø) ⬆️
packages/processor/lib/normalize.js 100% <100%> (ø)
packages/processor/plugins/graph-nodes.js 100% <100%> (ø) ⬆️
packages/processor/lib/graph-tiers.js 100% <100%> (+3.7%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 147c926...5268ac8. Read the comment docs.

tivac added some commits Nov 20, 2018

WIP: remove my wonky file deduping
true-case-path handles it better than I could anyways

This comment has been minimized.

Copy link

commented Nov 20, 2018

Hey @tivac,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: ddb72850-ec7f-11e8-9232-d3c7ef027538

@tivac tivac merged commit 2d4af90 into master Nov 20, 2018

4 checks passed

codecov/patch 100% of diff hit (target 98.87%)
codecov/project 98.99% (+0.11%) compared to 147c926
continuous-integration/travis-ci/pr The Travis CI build passed
continuous-integration/travis-ci/push The Travis CI build passed

@tivac tivac deleted the path-casing branch Nov 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.