Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework rollup support #531

merged 13 commits into from Dec 22, 2018


None yet
1 participant
Copy link

commented Dec 20, 2018

Take advantage of new functionality in rollup@0.68.0 and also rework the logic in the rollup plugin. Now it handles things like repeated chunk names, better deals with shared assets, and also fixed a nasty timing bug in processor.js that I somehow never caught before.

tivac added some commits Nov 26, 2018

WIP: sorta working
Broken for dynamic imports though, they're missing info we really need atm.
WIP: clean up a touch
Dynamic imports still failing: rollup/rollup#2553 (comment)
feat: Handle dynamic imports
BREAKING CHANGE: reworked CSS so it better matches rollup output chunk format

Also removed extraneous "rollup" directory from test output for easier visibility.
fix: Use entry name if code-splitting
To avoid any ugly double-hashed filenames.

Fixes #525
test: remove hash from results
It's not stable on other machines, which makes snapshots fail all over the place.
fix: properly wait for prior resolutions
There was a dependency ordering bug hiding in the old code, yikes!
refactor: remove lodash.foreach
Object.entries does what we need w/o any flopping around in a 3rd party lib.

This comment has been minimized.

Copy link

commented Dec 20, 2018

Codecov Report

Merging #531 into master will increase coverage by 0.11%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #531      +/-   ##
+ Coverage      99%   99.11%   +0.11%     
  Files          39       39              
  Lines         902      907       +5     
  Branches      137      135       -2     
+ Hits          893      899       +6     
+ Misses          9        8       -1
Impacted Files Coverage Δ
packages/browserify/browserify.js 97.84% <ø> (ø) ⬆️
packages/test-utils/read-dir.js 100% <ø> (ø) ⬆️
packages/processor/lib/output.js 100% <100%> (ø) ⬆️
packages/processor/plugins/values-replace.js 100% <100%> (ø) ⬆️
packages/processor/processor.js 100% <100%> (ø) ⬆️
packages/rollup/rollup.js 100% <100%> (+1.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c52345...aa11e23. Read the comment docs.

@tivac tivac merged commit fce87fe into master Dec 22, 2018

1 of 2 checks passed

continuous-integration/travis-ci/push The Travis CI build is in progress
continuous-integration/travis-ci/pr The Travis CI build passed

@tivac tivac deleted the rework-rollup branch Dec 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.