Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support mismatched case when invalidating #533

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
1 participant
@tivac
Copy link
Owner

commented Jan 9, 2019

The watchChange invalidation that landed in v19 was trying to be clever, which it turns out is a problem when your filenames might have mismatched cases (thanks Windows!).

Instead let the already-existing Processor logic inside .invalidate() handle it, and then just silently eat errors for files that the Processor doesn't know about.

NO TESTS because they'd never run on anything but a windows machine anyways and that's a PITA to set up.

@tivac tivac self-assigned this Jan 9, 2019

@codecov

This comment has been minimized.

Copy link

commented Jan 9, 2019

Codecov Report

Merging #533 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #533   +/-   ##
=======================================
  Coverage   99.13%   99.13%           
=======================================
  Files          40       40           
  Lines         924      924           
  Branches      139      138    -1     
=======================================
  Hits          916      916           
  Misses          8        8
Impacted Files Coverage Δ
packages/rollup/rollup.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6329461...251e280. Read the comment docs.

tivac added a commit that referenced this pull request Jan 9, 2019

fix: check for files via processor.has()
Means that files w/ incorrect cases are supported correctly, and supersedes #533
@tivac

This comment has been minimized.

Copy link
Owner Author

commented Jan 9, 2019

Fixed in a better way in b5a539b

@tivac tivac closed this Jan 9, 2019

@tivac tivac deleted the invalidation-cases branch Jan 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.