Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Webpack plugin to accept existing processor, and add test. #535

Merged
merged 2 commits into from Jan 11, 2019
Merged

Update Webpack plugin to accept existing processor, and add test. #535

merged 2 commits into from Jan 11, 2019

Conversation

@kevinkace
Copy link
Contributor

@kevinkace kevinkace commented Jan 10, 2019

Take 2! 馃槑

@codecov
Copy link

@codecov codecov bot commented Jan 10, 2019

Codecov Report

Merging #535 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #535   +/-   ##
=======================================
  Coverage   99.13%   99.13%           
=======================================
  Files          40       40           
  Lines         927      927           
  Branches      139      140    +1     
=======================================
  Hits          919      919           
  Misses          8        8
Impacted Files Coverage 螖
packages/webpack/plugin.js 94.87% <100%> (酶) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 6d29447...3529625. Read the comment docs.

Loading

Copy link
Owner

@tivac tivac left a comment

This is great, thanks!

One small request: would you also update packages/webpack/README.md w/ the new option? Here's the rollup version for reference.

Loading

@kevinkace
Copy link
Contributor Author

@kevinkace kevinkace commented Jan 11, 2019

Will do!

Loading

tivac
tivac approved these changes Jan 11, 2019
Copy link
Owner

@tivac tivac left a comment

馃憤馃徎x馃挴

Loading

@tivac tivac merged commit 15f1e15 into tivac:master Jan 11, 2019
3 checks passed
Loading
@tivac
Copy link
Owner

@tivac tivac commented Jan 11, 2019

This is released in @modular-css/webpack@19.2.0. Thanks again @kevinkace!

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants