Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: clean up rollup chunk naming & source maps #537

merged 11 commits into from Jan 15, 2019


None yet
1 participant
Copy link

commented Jan 15, 2019

Another day, another big reshuffling of all this logic. I'll get it right someday, right?

This fixes #536 along with a host of other bugs that were preventing source maps from even being close to working. This requires a lot of flopping around to get right & work around limitations in what rollup gives us for asset details and limitations in the asset API (like not being able to get the hash until the file is written, but needing the hash for the final name when calling postcss...). It's inelegant and starting to get crazy-looking but it's functional and the tests are at least pretty thorough at this point.


tivac added some commits Jan 15, 2019

WIP: fix chunk naming
Still fighting through maps though.

Working to fix #536
WIP: unused rollup filename parser
Don't need it for this, but seems worth keeping around.
fix: Properly handle chunk incrementing
Also fixes:

- Source map annotations in CSS files don't include hash
- Source map files have incorrect names
test: include source maps in more tests
Spent all that time fixing 'em, might as well test it too.

@tivac tivac self-assigned this Jan 15, 2019


This comment has been minimized.

Copy link

commented Jan 15, 2019

Codecov Report

Merging #537 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #537      +/-   ##
+ Coverage   99.13%   99.16%   +0.02%     
  Files          40       41       +1     
  Lines         927      960      +33     
  Branches      140      147       +7     
+ Hits          919      952      +33     
  Misses          8        8
Impacted Files Coverage 螖
packages/rollup/rollup.js 100% <100%> (酶) 猬嗭笍
packages/rollup/parser.js 100% <100%> (酶)

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 87ea915...e946e52. Read the comment docs.

@tivac tivac merged commit dfef6ba into master Jan 15, 2019

4 checks passed

codecov/patch 100% of diff hit (target 99.13%)
codecov/project 99.16% (+0.02%) compared to 87ea915
continuous-integration/travis-ci/pr The Travis CI build passed
continuous-integration/travis-ci/push The Travis CI build passed

@tivac tivac deleted the rollup-chunk-maps branch Jan 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.