Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support circular dependencies #541

Merged
merged 4 commits into from Jan 18, 2019

Conversation

Projects
None yet
1 participant
@tivac
Copy link
Owner

commented Jan 18, 2019

Description

The dependency-graph instance used in the rollup plugin for tracking JS chunk usage of CSS files needed to have circular dependency support turned on.

Motivation and Context

Fixes #539

How Has This Been Tested?

Added test specimens that introduced a circular dependency, added test to run them, test passes after change and output looks correct.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@tivac tivac self-assigned this Jan 18, 2019

@codecov

This comment has been minimized.

Copy link

commented Jan 18, 2019

Codecov Report

Merging #541 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #541   +/-   ##
=======================================
  Coverage   99.16%   99.16%           
=======================================
  Files          41       41           
  Lines         962      962           
  Branches      148      148           
=======================================
  Hits          954      954           
  Misses          8        8
Impacted Files Coverage Δ
packages/rollup/rollup.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e1e25b9...e7e1fdd. Read the comment docs.

@tivac tivac merged commit b8dce99 into master Jan 18, 2019

4 checks passed

codecov/patch 100% of diff hit (target 99.16%)
Details
codecov/project 99.16% (+0%) compared to e1e25b9
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@tivac tivac deleted the circular-dependencies branch Jan 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.