Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support chunks that don't depend on css #544

Merged
merged 5 commits into from Jan 18, 2019

Conversation

Projects
None yet
1 participant
@tivac
Copy link
Owner

commented Jan 18, 2019

Description

Filter dependencies before trying to map them to ensure that chunks w/ no CSS dependencies don't throw errors.

Motivation and Context

Fixes #543

How Has This Been Tested?

Included tests.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@tivac tivac self-assigned this Jan 18, 2019

@codecov

This comment has been minimized.

Copy link

commented Jan 18, 2019

Codecov Report

Merging #544 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #544      +/-   ##
==========================================
+ Coverage   99.17%   99.17%   +<.01%     
==========================================
  Files          41       41              
  Lines         970      971       +1     
  Branches      149      149              
==========================================
+ Hits          962      963       +1     
  Misses          8        8
Impacted Files Coverage Δ
packages/rollup/rollup.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5665237...f17438a. Read the comment docs.

@tivac tivac merged commit 10074e3 into master Jan 18, 2019

4 checks passed

codecov/patch 100% of diff hit (target 99.17%)
Details
codecov/project 99.17% (+<.01%) compared to 5665237
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@tivac tivac deleted the cssless-dependencies branch Jan 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.